-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the repo into a Cargo workspace #32
Conversation
Group Hash implementation in the circuit
Tidy up the codebase (TODOs into github issues)
…n hash (in the context of a merkle tree).
Pedersen hashes inside and outside the circuit
… longer necessary.
Edwards scalar multiplication inside the circuit
Implement Sapling components of ZIP 32
ACK |
I added the
and then modified all the crates in the workspace to correctly depend on each other. |
Why did we suddenly inherit all these new packages in |
Nevermind, I guess we can't avoid it. Cargo will want all the There are some packages that could be updated, but we shouldn't do that in this PR. Side note, here is what gets compiled now:
I'd love for us to eventually do the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
d0ea5d4 Merge pull request zcash#32 from narodnik/sum 24aa1a4 Merge pull request zcash#31 from zkcrypto/release-0.1.1 fb7c4cb add cargo fmt for sum traits (code we added) ccef392 add sum iterator implementations 82e14ed Release 0.1.1 a3608d4 Put endo optimizations behind endo crate feature. e32494e Merge pull request zcash#18 from mmaker/master 948b199 Fix typo in comment. b3d1fe1 Merge pull request zcash#27 from rex4539/fix-typos 253f681 Merge pull request zcash#25 from mmaker/fix/sage-script c55f88f Fix typos 14b5e16 No need to define a polynomial ring in notes/design.rs. c9d17f6 Make sage script in notes/design.rs work with sage 3.9. af9ec4d Minor changes to comments documenting `clear_cofactor` 7dc6f31 Add clear_cofactor. git-subtree-dir: bls12_381 git-subtree-split: d0ea5d4958cae999dea1800207704171aa07a9ef
38d38af3 Merge pull request zcash#32 from kevaundray/patch-1 af5598da Merge pull request zcash#33 from ZcashFoundation/scalar 109ec40d Add public Scalar type alias for Fr 8e9c5fe6 typo in Fr.rs 8e9337ee Merge pull request zcash#30 from rex4539/typos 5f4374c8 Fix typo git-subtree-dir: jubjub git-subtree-split: 38d38af3b792d2c55d815d214a7cd157dc8f71ad
The
librustzcash
crate is now a library inside the workspace.Several new libraries have been created, which we can refactor existing code into. We can also reorganise code between them more seamlessly than if they were split across several repositories.
If we later want to extract a library into a separate repository, we can use
git subtree split
.