FSStore: default to normalize_keys=False #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 28 28
Lines 10537 10537
=======================================
Hits 10531 10531
Misses 6 6
|
shoyer
approved these changes
May 19, 2021
|
Worth getting this out as a quick 2.8.3? |
sounds good to me! |
|
Sleep got in the way! Actioning now. |
tmieslinger
added a commit
to tmieslinger/how_to_eurec4a
that referenced
this pull request
May 20, 2021
* zarr PR was just merged to set default for normalize_keys to False * see zarr-developers/zarr-python#755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #739
Set normalize_keys to False by default to have unification across all the store implementations.
TODO: