-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
top-level functions for reading, creating data #2463
Conversation
in writing this PR I noticed that we don't have a |
I'm wrong, we don't have |
This is ready for review. To summarize: I created 5 new top-level exports:
The goal for these functions is to directly support common access patterns without forcing users to worry about the semantics of the |
Some feedback from the community meeting last week:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Just one comment of substance. Let's get this in and start using it.
Co-authored-by: Joe Hamman <[email protected]>
…7489) # References and relevant issues Closes: #7484 # Description The latest --pre fail is due to recent changes in zarr released in 3.0.0rc1: zarr-developers/zarr-python#2463 JNI already has an issue and PR to fix upstream, so lets just block this rc.
adds async and sync
read_array
,read_group
, andread
functions.read_array
will read an array from storage.read_group
does the same, but for groups, andread
will try to read arrays or groups at the storage path. These functions wrap their respective creation functions, passingmode=r
in each case.I still need to add tests.
TODO: