Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compressors, filters, serializer to Array as attributes #2633

Closed
d-v-b opened this issue Jan 3, 2025 · 0 comments · Fixed by #2652
Closed

add compressors, filters, serializer to Array as attributes #2633

d-v-b opened this issue Jan 3, 2025 · 0 comments · Fixed by #2652
Assignees

Comments

@d-v-b
Copy link
Contributor

d-v-b commented Jan 3, 2025

#2463 added a new function for creating arrays that abstracts over the painful fact that v2 arrays and v3 arrays have overlapping-but-distinct specifications of how chunks are encoded. This function expresses the v2 and v3 chunk encoding specs via 3 keyword arguments:

  • filters (filters in v2 , the array_array_codecs elements of the codecs list attribute in v3)
  • serializer (implicit in v2, the array_bytes_codec element of the codecs list attribute in v3)
  • compressors (compressor in v2 (note the singular), bytes_bytes_codec elements of the codecs list attribute in v3)

logically, these terms describe "transformations made to chunks when they are n-dimensional arrays", "the transformation that turns an n-dimensional array into a flat bytestream", and "transformations made to chunks after they are flattened to bytestreams"

but we don't expose filters, serializer, compressors as attributes on the Array class, which is probably where users will expect to find them. So I'm proposing that we add filters, serializer, compressors to the Array class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants