1247 configure/review page redesign #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noxsios
requested review from
mike-winberry,
Racer159,
jeff-mccoy and
YrrepNoj
as code owners
|
|
Noxsios
added a commit
that referenced
this pull request
Mar 8, 2023
## Description This PR introduces some updates to the `configure` and `review` pages, tweaking the section header components. To accomplish this, two new complex components were introduced: - `Tooltip` - powered by [Floating UI](https://floating-ui.com/) (popperJS 3.0) In addition to the above, there are some refactoring on how theming works across Zarf UI, with the introduction of using the `html` `data-theme` property until such time that Unicorn UI's theming is fully mature. ## Related Issue Fixes #1247 ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some updates to the
configureandreviewpages, tweaking the section header components. To accomplish this, two new complex components were introduced:Tooltip- powered by Floating UI (popperJS 3.0)In addition to the above, there are some refactoring on how theming works across Zarf UI, with the introduction of using the
htmldata-themeproperty until such time that Unicorn UI's theming is fully mature.Related Issue
Fixes #1247
Type of change
Checklist before merging