Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure/Review page redesign #1247

Closed
Noxsios opened this issue Jan 23, 2023 · 0 comments · Fixed by #1252
Closed

Configure/Review page redesign #1247

Noxsios opened this issue Jan 23, 2023 · 0 comments · Fixed by #1252
Assignees
@Noxsios
Labels
enhancement ✨ New feature or request ux
Milestone
v0.26.1 (Zarf UI)

Comments

@Noxsios
Copy link
Contributor

Noxsios commented Jan 23, 2023

From the Figma spec, update the configure + review pages for better UX.

Screenshot 2023-01-23 at 12 12 20 PM
@Noxsios Noxsios added enhancement ✨ New feature or request ux UI labels Jan 23, 2023
@Noxsios Noxsios added this to the Zarf UI milestone Jan 23, 2023
@Noxsios Noxsios self-assigned this Jan 23, 2023
@Noxsios Noxsios linked a pull request Jan 23, 2023 that will close this issue
1247 configure/review page redesign #1252
Merged
3 tasks
@Noxsios Noxsios mentioned this issue Jan 23, 2023
Merged
3 tasks
jeff-mccoy pushed a commit that referenced this issue Jan 25, 2023
@Noxsios
1247 configure/review page redesign (#1252)
62a70b6 
## Description

This PR introduces some updates to the `configure` and `review` pages,
tweaking the section header components. To accomplish this, two new
complex components were introduced:

- `Tooltip` - powered by [Floating UI](https://floating-ui.com/)
(popperJS 3.0)

In addition to the above, there are some refactoring on how theming
works across Zarf UI, with the introduction of using the `html`
`data-theme` property until such time that Unicorn UI's theming is fully
mature.

## Related Issue

Fixes #1247 

## Type of change

- [x] New feature (non-breaking change which adds functionality)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Noxsios added a commit that referenced this issue Mar 8, 2023
@Noxsios
1247 configure/review page redesign (#1252)
82136db 
## Description

This PR introduces some updates to the `configure` and `review` pages,
tweaking the section header components. To accomplish this, two new
complex components were introduced:

- `Tooltip` - powered by [Floating UI](https://floating-ui.com/)
(popperJS 3.0)

In addition to the above, there are some refactoring on how theming
works across Zarf UI, with the introduction of using the `html`
`data-theme` property until such time that Unicorn UI's theming is fully
mature.

## Related Issue

Fixes #1247 

## Type of change

- [x] New feature (non-breaking change which adds functionality)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Noxsios Noxsios

Labels
enhancement ✨ New feature or request ux
Projects
None yet
Milestone
v0.26.1 (Zarf UI)
Development

Successfully merging a pull request may close this issue.

1247 configure/review page redesign zarf-dev/zarf
1 participant
@Noxsios