Update value of localPath for composable packages

[tworcester]

Description

Related Issue

Fixes #1153

Type of change

• Bug fix (non-breaking change which fixes an issue)

[jeff-mccoy]

Thanks @tworcester we're waiting on #1173 to resolve issues around 3rd-party PRs

[jeff-mccoy]

This is being weird, can you take a look at it again @tworcester?

[tworcester]

This is being weird, can you take a look at it again @tworcester?

Sure thing, the test failures?

[tworcester]

@jeff-mccoy Please try again, I believe I fixed the issue. I ran the tests locally but not the init-package 🤦

[tworcester]

Do we want to provide the ability to respect a full file path? If people already using zarf have worked around this issue prior to this change, this would break them similar to what we saw above.

I think checking the provided localPath to see if it contains the zarf subcomponent folder already before adjusting would be defensive enough. Thoughts?

[jeff-mccoy]

Yeah I think that sounds reasonable and would prevent this from being a breaking change, even though it's also a bug fix.

[jeff-mccoy]

Add sanity check for existing behavior (component path in import path) to support existing broken behavior. Should leave a warning to the user noting this is incorrect.

[jeff-mccoy]

Changing to draft to make tracking easier. Please complete the requested changes and then change back to ready for review, thanks!

[tworcester]

Changing to draft to make tracking easier. Please complete the requested changes and then change back to ready for review, thanks!

Thank you! I likely won’t have time to get to this until next week. (Just wanted to drop a note so you know I haven’t dropped it)

[jeff-mccoy]

not a problem at all, we may pick up the rest this week if we can squeeze it in, thanks!

[YrrepNoj]

Eventually ™️, I think it would be a good idea to not even bother with the os.Stat() files from the parent directory perspective. Even though it's pretty unlikely, I think it's not that intuitive.

Of course since it's old behavior that we're trying not to break, it makes 110% sense to include in this PR for now!

[tworcester]

Thank you for wrapping this up, apologies for being absent!