Scripts -> Actions #1144
Merged
Scripts -> Actions #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automatic conversion of |
jeff-mccoy
added
needs-adr
needs-docs
…nto jeff-doing-stupid-jeff-things
|
Added basic mermaid to show the cycle of component actions |
|
It's ugly for now, but does warn the users. |
|
Does the schema file need to be updated? Edit: no? I see
|
Not sure which IDE that is, but for VSCode at least it is in settings.json. You also may need to restart your IDE after switching branches (at least VS Code requires a restart) |
…nto jeff-doing-stupid-jeff-things
YrrepNoj
reviewed
Jan 24, 2023
Racer159
requested changes
Jan 24, 2023
Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
YrrepNoj
approved these changes
Jan 24, 2023
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
## Related Issues Related to #939 Fixes #1137, #1022 ### Backwards compatible replacement of simple `scripts` with complex `actions` - [x] Define types - [x] `package create` transparent migration - [x] `package deploy` transparent migration - [x] Introduce deprecation pattern into `src/pkg/packager` - [x] Package`Create` actions: `Before`, `After`, `Success`, `Failure` - [x] Package`Deploy` actions: `Before`, `After`, `Success`, `Failure` - [x] Package`Remove` actions: `Before`, `After`, `Success`, `Failure` ### Other refactors - [x] Expand exec to support env variables, add config struct - [x] Add common cmd defaults - [x] Add set working dir support - [x] Inject deploy-time variables as env variables for `onDeploy` - [x] Expand sha256sum function to support any generic crypto hash type Co-authored-by: Wayne Starr <[email protected]> Co-authored-by: Jon Perry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related to #939
Fixes #1137, #1022
Backwards compatible replacement of simple
scriptswith complexactionspackage createtransparent migrationpackage deploytransparent migrationsrc/pkg/packagerCreateactions:Before,After,Success,FailureDeployactions:Before,After,Success,FailureRemoveactions:Before,After,Success,FailureOther refactors
onDeploy