-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/exclude add when initial zappa setting #1242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a testcase to confirm the results of this?
I wrote a test code to check if excludes are properly included in zappa_settings when I run zappa init. It's the first time I've written test code in Python, so I'd appreciate it if you could check if the test code was written clearly. In addition, when there is something in the exclude, please tell me if you need to write a test code to see if it is excluded well in the zip. thank you! |
@kyaryunha I feel it should be labeled as a breaking change. |
Yes, this code conflicts with the old zappa_settings.json. |
Ah.. ci failed... |
Consider django_settings (zappa latest version)
I fixed my test code. Could you please run ci again? |
Description
My prev pull request is bad because it always disable boto.
So I code a new idea about this mention.
#1235 (comment)
GitHub Issues
My Prev Pull Request: #1235
Issue: #1241