Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable default excludes #1241

Closed
sridhar562345 opened this issue May 4, 2023 · 3 comments
Closed

Option to disable default excludes #1241

sridhar562345 opened this issue May 4, 2023 · 3 comments
Labels
auto-closed [Bot] Closed, details in comments no-activity [Bot] Closing soon if no new activity

Comments

@sridhar562345
Copy link
Contributor

Excluding boto3 and botocore by default is good, but there might be cases when the user has to use a newer version of boto3 that's not available on lambda. Currently, there is a workaround as below.

exclude = self.stage_config.get("exclude", ["boto3", "dateutil", "botocore", "s3transfer", "concurrent"])

To use newer version of boto3, specify exclude in zappa_settings.json which will override the default excludes

"exclude": ["file.txt"]

#1235 will modify this snippet, but we won't be able to use the newer boto3 version at all.

exclude = self.stage_config.get("exclude",
exclude += ["boto3", "dateutil", "botocore", "s3transfer", "concurrent"]

So having the option to disable default excludes would be better.

@monkut
Copy link
Collaborator

monkut commented Aug 14, 2023

After the 3.11 release, let's try to get this in.

Copy link

github-actions bot commented Apr 3, 2024

Hi there! Unfortunately, this Issue has not seen any activity for at least 90 days. If the Issue is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed.

@github-actions github-actions bot added the no-activity [Bot] Closing soon if no new activity label Apr 3, 2024
Copy link

Hi there! Unfortunately, this Issue was automatically closed as it had not seen any activity in at least 100 days. If the Issue is still relevant to the latest version of Zappa, please open a new Issue.

@github-actions github-actions bot added the auto-closed [Bot] Closed, details in comments label Apr 13, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-closed [Bot] Closed, details in comments no-activity [Bot] Closing soon if no new activity
Projects
None yet
Development

No branches or pull requests

2 participants