Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): hide sensitive data from error messages #87

Closed
wants to merge 3 commits into from
Closed

fix(core): hide sensitive data from error messages #87

wants to merge 3 commits into from

Conversation

eliangcs
Copy link
Member

DO NOT MERGE! This PR is exactly the same as #85. The branch is checked out from 8.4.0 and is just for us to release it in 8.4.1.

@eliangcs eliangcs requested a review from xavdid as a code owner October 21, 2019 09:13
@xavdid
Copy link
Contributor

xavdid commented Oct 21, 2019

I was having trouble with the merge, so I re-committed the pertinent bits of #84 in 1d56b26.

Given that both changes are already in master, I think we can safely release this as 8.4.1 and then close the branch and never merge it (like you mentioned).

@eliangcs eliangcs closed this Oct 22, 2019
@eliangcs eliangcs deleted the hide-url-query-in-error-messages branch October 22, 2019 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavdid xavdid xavdid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliangcs @xavdid