fix(core): hide sensitive data from error messages #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
Cool, so this does solve the problem.
I'm wondering if there was a reason you didn't keep the query, but use the existing censoring tools. I can imagine a situation where it's helpful to see the innocuous query contents while ensuring we don't leak secret things.
I'm also worried that there are other situations where data in the auth mapping doesn't get censored (since it's not added to bundle.authData or process.env, what we source the secure bundle from.
In any case, this is probably fine to ship. thanks for grabbing!
eliangcs
changed the title
eliangcs
force-pushed
the
strip-querystring-from-error-message
branch
from
27a78de to
c737413
Compare
eliangcs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL querystring may contain sensitive data so shouldn't be shown in the error message.
Fixes https://github.com/zapier/zapier/issues/32319.