Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NgRx Integration example #623

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Conversation

timdeschryver
Copy link
Contributor

  • Links pointing to the docs website
  • Update implementation to complement new NgRx versions

- Links pointing to the docs website
- Update implementation to complement new NgRx versions
@zalmoxisus
Copy link
Owner

zalmoxisus commented Jan 6, 2019

Thanks! Do you know if Book Collection demo link specified there and in README is up to date? According to #589 (comment) it wasn't.

Would be great to provide a demo so we could probably add it in e2e tests in future to avoid regressions. I guess after Redux, NgRx is the most popular library using our extension, so it would deserve some tests.

@timdeschryver
Copy link
Contributor Author

We got a new example at https://ngrx.github.io/platform/example-app/#/login but requires a login (username: test, password: doesn't matter). That's why I've left the old example app. I do agree that it would be better to have the new one, I'll add an extra commit with these changes.

@zalmoxisus
Copy link
Owner

@timdeschryver looks like the new demo has some issues using the extension. Nothing appears on the extension's side.

@timdeschryver
Copy link
Contributor Author

🤦‍♂️ you're right, thanks for noticing it!
The example app is also already a year old. Give me some time and I'll see what I can do in order to have the example app updated, with the extension on 😄

@zalmoxisus
Copy link
Owner

zalmoxisus commented Jan 7, 2019

Take your time, thanks for working on that 😀

@zalmoxisus zalmoxisus merged commit 8f524f2 into zalmoxisus:master Jan 7, 2019
@zalmoxisus
Copy link
Owner

Thanks again for the contribution! I've started a complete rewrite of the extension for 3.0, then will add proper e2e tests for ngrx.

@timdeschryver timdeschryver deleted the patch-1 branch January 8, 2019 18:06
@timdeschryver
Copy link
Contributor Author

Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants