-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NgRx Integration example #623
Conversation
timdeschryver
commented
Jan 6, 2019
- Links pointing to the docs website
- Update implementation to complement new NgRx versions
- Links pointing to the docs website - Update implementation to complement new NgRx versions
Thanks! Do you know if Book Collection demo link specified there and in README is up to date? According to #589 (comment) it wasn't. Would be great to provide a demo so we could probably add it in e2e tests in future to avoid regressions. I guess after Redux, NgRx is the most popular library using our extension, so it would deserve some tests. |
We got a new example at https://ngrx.github.io/platform/example-app/#/login but requires a login (username: test, password: doesn't matter). That's why I've left the old example app. I do agree that it would be better to have the new one, I'll add an extra commit with these changes. |
@timdeschryver looks like the new demo has some issues using the extension. Nothing appears on the extension's side. |
🤦♂️ you're right, thanks for noticing it! |
Take your time, thanks for working on that 😀 |
Thanks again for the contribution! I've started a complete rewrite of the extension for |
Sounds great! |