Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update example app #1506

Merged
merged 1 commit into from
Jan 7, 2019
Merged

docs: update example app #1506

merged 1 commit into from
Jan 7, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

Would it be OK to update the example app deployed on GitHub?

Things I've changed to make it imho easier for users taking a look:

  • enable actions in the devtools
  • also enable login with ngrx, which is also prefilled in the username textbox

We could also make these changes on the master branch?

I didn't update the StackBlitz example, because it can't handle the aliased paths defined in tsconfig.app.json.

Related: this is in order to update the NgRx documentation for the Redux Dev Tools extension, which were based on NgRx version 2 - zalmoxisus/redux-devtools-extension#623

@brandonroberts
Copy link
Member

What changes were made to the actual example app for this?

@timdeschryver
Copy link
Member Author

Removed log only - this to play around with the extension, plus zalmoxisus/redux-devtools-extension#623 (comment)
image

Allow ngrx as username, to make it more pleasing:
image

Defaulted to ngrx as username, to make it easier to login without the need to take a look at the source code:
image

@timdeschryver
Copy link
Member Author

If you would rather not update the example app or to deploy it without the changes, that's fine by me too 😄

@brandonroberts
Copy link
Member

Deploying without updating is fine if these changes are temporary.

@brandonroberts brandonroberts merged commit 7fa4ea9 into gh-pages Jan 7, 2019
@brandonroberts brandonroberts deleted the upgrade-gh-pages-app branch January 7, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants