filters: deprecate OpenTracing in FilterContext #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate OpenTracing FilterContext getters and remove their usage from filters. For #2104 Signed-off-by: Alexander Yastrebov <[email protected]>
| @@ -599,7 +599,7 @@ func (opa *OpenPolicyAgentInstance) startSpanFromContextWithTracer(tr opentracin | |||
| } | |||
|
|
|||
| func (opa *OpenPolicyAgentInstance) StartSpanFromFilterContext(fc filters.FilterContext) (opentracing.Span, context.Context) { | |||
| return opa.startSpanFromContextWithTracer(fc.Tracer(), fc.ParentSpan(), fc.Request().Context()) | |||
| return opa.StartSpanFromContext(fc.Request().Context()) | |||
There was a problem hiding this comment.
@mjungsbluth BTW I am not sure why OPA needs a whole set of opentracing helpers.
I think it should get tracer from its options and for synchronous filter requests it should get proxy span (and its tracer if needed) via opentracing.SpanFromContext(ctx.Request().Context())
There was a problem hiding this comment.
@AlexanderYastrebov It should be fine the way you outlined. It was probably overly defensive to include the tracer for cases where the context does not already contain a span (which actually don't provide much value for the synchronous cases).
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
deleted the
filters/deprecate-filter-context-opentracing
branch
Comment on lines
+119
to
+120
| // Filter spans should be children of the proxy span, | ||
| // use opentracing.SpanFromContext(ctx.Request().Context()) to get the proxy span. |
There was a problem hiding this comment.
AlexanderYastrebov
added a commit
that referenced
this pull request
Apr 29, 2024
The ParentSpan is not a proxy span but either ingress span of "filters" span when enabled. Follow up on #3044 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Apr 29, 2024
…#3052) The ParentSpan is not a proxy span but either ingress span of "filters" span when enabled. Follow up on #3044 Signed-off-by: Alexander Yastrebov <[email protected]>
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Jul 19, 2024
Deprecate OpenTracing FilterContext getters and remove their usage from filters. For zalando#2104 Signed-off-by: Alexander Yastrebov <[email protected]>
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Jul 19, 2024
…zalando#3052) The ParentSpan is not a proxy span but either ingress span of "filters" span when enabled. Follow up on zalando#3044 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate OpenTracing FilterContext getters and remove their usage from filters.
For #2104