Skip to content

Commit

Permalink
filters: update godoc for deprecated FilterContext OpenTracing fields (
Browse files Browse the repository at this point in the history
…zalando#3052)

The ParentSpan is not a proxy span but either ingress span of "filters"
span when enabled.

Follow up on zalando#3044

Signed-off-by: Alexander Yastrebov <[email protected]>
  • Loading branch information
AlexanderYastrebov authored and Janardhan Sharma committed Jul 19, 2024
1 parent f6382f7 commit 08e1928
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions filters/filters.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,14 @@ type FilterContext interface {
// Allow filters to add Tags, Baggage to the trace or set the ComponentName.
//
// Deprecated: OpenTracing is deprecated, see https://github.com/zalando/skipper/issues/2104.
// Use opentracing.SpanFromContext(ctx.Request().Context()).Tracer() to get the proxy span Tracer.
// Use opentracing.SpanFromContext(ctx.Request().Context()).Tracer() to get the Tracer.
Tracer() opentracing.Tracer

// Allow filters to create their own spans
//
// Deprecated: OpenTracing is deprecated, see https://github.com/zalando/skipper/issues/2104.
// Filter spans should be children of the proxy span,
// use opentracing.SpanFromContext(ctx.Request().Context()) to get the proxy span.
// Filter spans should be children of the request span,
// use opentracing.SpanFromContext(ctx.Request().Context()) to get it.
ParentSpan() opentracing.Span

// Returns a clone of the FilterContext including a brand new request object.
Expand Down

0 comments on commit 08e1928

Please sign in to comment.