Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdp: disable testcontainers Ryuk #2932

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

AlexanderYastrebov
Copy link
Member

Disable reaper container for CDP builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk and previous #2930

Updates #2668
Updates #2621
Updates #2556

Disable reaper container for CDP builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk
and previous #2930

Updates #2668
Updates #2621
Updates #2556

Signed-off-by: Alexander Yastrebov <[email protected]>
@szuecs szuecs added the minor no risk changes, for example new filters label Feb 13, 2024
@szuecs
Copy link
Member

szuecs commented Feb 13, 2024

👍

1 similar comment
@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit 92e14cf into master Feb 13, 2024
14 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the build/disable-ryuk-cdp branch February 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor no risk changes, for example new filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants