github: disable testcontainers Ryuk #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable reaper container for github builds. This should hopefully eliminate testcontainer-related test flakes. See https://golang.testcontainers.org/features/garbage_collector/#ryuk Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
github/disable-testcontainers-ryuk
branch
from
6c6e481
to
0c3efe3
Compare
AlexanderYastrebov
changed the title
|
Same would need to be done in CDP (delivery.yaml) right? |
|
👍 |
I think we observe testcontainers related flakes mostly on github builders. |
|
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Feb 13, 2024
Disable reaper container for CDP builds. This should hopefully eliminate testcontainer-related test flakes. See https://golang.testcontainers.org/features/garbage_collector/#ryuk and previous #2930 Updates #2668 Updates #2621 Updates #2556 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Feb 13, 2024
Disable reaper container for CDP builds. This should hopefully eliminate testcontainer-related test flakes. See https://golang.testcontainers.org/features/garbage_collector/#ryuk and previous #2930 Updates #2668 Updates #2621 Updates #2556 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable reaper container for github builds.
This should hopefully eliminate testcontainer-related test flakes.
See https://golang.testcontainers.org/features/garbage_collector/#ryuk
Updates #2668
Updates #2621
Updates #2556