Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: use redis 7 #2895

Merged
merged 1 commit into from
Feb 9, 2024
Merged

net: use redis 7 #2895

merged 1 commit into from
Feb 9, 2024

Conversation

AlexanderYastrebov
Copy link
Member

@AlexanderYastrebov AlexanderYastrebov commented Jan 30, 2024

Signed-off-by: Alexander Yastrebov <[email protected]>
@AlexanderYastrebov AlexanderYastrebov added the major moderate risk, for example new API, small filter changes that have no risk like refactoring or logs label Jan 30, 2024
@szuecs
Copy link
Member

szuecs commented Feb 7, 2024

👍

@szuecs szuecs added minor no risk changes, for example new filters and removed major moderate risk, for example new API, small filter changes that have no risk like refactoring or logs labels Feb 7, 2024
@szuecs
Copy link
Member

szuecs commented Feb 7, 2024

I downgraded to minor, because it only changes redistest package

@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit be4ef50 into master Feb 9, 2024
14 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the net/redis-7 branch February 9, 2024 14:46
AlexanderYastrebov added a commit that referenced this pull request Feb 20, 2024
Update https://github.com/redis/go-redis/releases/tag/v9.5.0
broke support of redis:6

Unfortunately we did not catch it because we updated test redis to
redis:7 recently, see #2895

This change adds test to verify client supports both redis:6 and redis:7

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this pull request Feb 20, 2024
Update #2941 of go-redis to https://github.com/redis/go-redis/releases/tag/v9.5.0
broke support of redis:6

Unfortunately we did not catch it because we updated test redis to
redis:7 recently, see #2895

This change updates go-redis to https://github.com/redis/go-redis/releases/tag/v9.5.1
and adds a test to verify it supports both redis:6 and redis:7

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit to zalando-incubator/kubernetes-on-aws that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor no risk changes, for example new filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants