Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipper: use redis 7 #6854

Merged
merged 1 commit into from
Feb 28, 2024
Merged

skipper: use redis 7 #6854

merged 1 commit into from
Feb 28, 2024

Conversation

AlexanderYastrebov
Copy link
Member

@AlexanderYastrebov AlexanderYastrebov commented Jan 30, 2024

@AlexanderYastrebov AlexanderYastrebov added the major Major feature changes or updates, e.g. feature rollout to a new country, new API calls. label Jan 30, 2024
@AlexanderYastrebov AlexanderYastrebov force-pushed the skipper/redis-7 branch 2 times, most recently from e6ecbd3 to b791116 Compare February 27, 2024 10:13
@AlexanderYastrebov AlexanderYastrebov marked this pull request as ready for review February 27, 2024 17:21
@szuecs
Copy link
Member

szuecs commented Feb 27, 2024

I don't like that "refactoring" no-op is mixed with image change.
Why do we need to have indentation and version "fixes"?

@AlexanderYastrebov
Copy link
Member Author

I don't like that "refactoring" no-op is mixed with image change.
Why do we need to have indentation and version "fixes"?

I thought to make it a valid yaml on the go (by putting template actions into yaml comments) but we can split this change in two so I reverted to version+image change only.

@RomanZavodskikh
Copy link
Member

👍

@@ -3,7 +3,7 @@ kind: StatefulSet
metadata:
labels:
application: skipper-ingress-redis
version: v6.2.7
version: v7.2.4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~$ docker run --rm container-registry.zalando.net/library/redis-7-alpine:7-alpine-20240226 redis-server --version
Redis server v=7.2.4 sha=00000000:0 malloc=jemalloc-5.3.0 bits=64 build=f17de61a0b604ef3

@szuecs
Copy link
Member

szuecs commented Feb 28, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major feature changes or updates, e.g. feature rollout to a new country, new API calls. merged/alpha merged/beta merged/kube-1.26 merged/stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants