Implements HTTPS graceful shutdown #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
https-graceful-shutdown
branch
5 times, most recently
from
a9466fa to
938db16
Compare
AlexanderYastrebov
changed the title
Fixes #1865 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
https-graceful-shutdown
branch
from
938db16 to
ab90620
Compare
szuecs
reviewed
Sep 27, 2021
| } | ||
|
|
||
| func testServerShutdown(t *testing.T, o *Options, scheme string) { | ||
| const shutdownDelay = 1 * time.Second |
There was a problem hiding this comment.
this is a d if you are writing Go :)
If you write Java you can name it as in Java :)
There was a problem hiding this comment.
In java that would be HasThisTypePatternTriedToSneakInSomeGenericOrParameterizedTypePatternMatchingStuffAnywhereVisitor ☝️
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Jul 12, 2023
PR #1866 implemented HTTPS graceful shutdown but did not use queuelistener. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Jul 24, 2023
PR #1866 implemented HTTPS graceful shutdown but did not use queuelistener. Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1865
Signed-off-by: Alexander Yastrebov [email protected]