Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown is not working in HTTPS mode #1865

Closed
AlexanderYastrebov opened this issue Sep 23, 2021 · 0 comments · Fixed by #1866
Closed

Graceful shutdown is not working in HTTPS mode #1865

AlexanderYastrebov opened this issue Sep 23, 2021 · 0 comments · Fixed by #1866
Assignees
@AlexanderYastrebov

Comments

@AlexanderYastrebov
Copy link
Member

Describe the bug

#988 implemented graceful shutdown but it is not working in HTTPS mode because of an early return:

skipper/skipper.go

Line 1053 in 27f4849

return srv.ListenAndServeTLS(o.CertPathTLS, o.KeyPathTLS)

To Reproduce

  1. Run Skipper in HTTPS mode
$ bin/skipper -tls-cert=fixtures/test.crt -tls-key=fixtures/test.key -inline-routes '* -> status(204) -> <shunt>'
  1. Send SIGTERM
$ kill -SIGTERM $(pgrep skipper)
  1. Observe immediate shutdown

Expected behavior

Graceful shutdown like in HTTP mode, e.g. the logs:

Got shutdown signal, wait 45s for health check
AlexanderYastrebov added a commit that referenced this issue Sep 23, 2021
@AlexanderYastrebov
wip: HTTPS graceful shutdown
9453497 
Fixes #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
@AlexanderYastrebov AlexanderYastrebov self-assigned this Sep 23, 2021
@AlexanderYastrebov AlexanderYastrebov mentioned this issue Sep 23, 2021
Merged
AlexanderYastrebov added a commit that referenced this issue Sep 24, 2021
@AlexanderYastrebov
Implements HTTPS graceful shutdown
ec35f59 
Fixes #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this issue Sep 24, 2021
@AlexanderYastrebov
Implements HTTPS graceful shutdown
4a0106d 
Fixes #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this issue Sep 24, 2021
@AlexanderYastrebov
Implements HTTPS graceful shutdown
82a8128 
Fixes #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this issue Sep 24, 2021
@AlexanderYastrebov
Implements HTTPS graceful shutdown
a9466fa 
Fixes #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this issue Sep 24, 2021
@AlexanderYastrebov
Implements HTTPS graceful shutdown
938db16 
Fixes #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this issue Sep 24, 2021
@AlexanderYastrebov
Implements HTTPS graceful shutdown
ab90620 
Fixes #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this issue Sep 27, 2021
@AlexanderYastrebov
Implements HTTPS graceful shutdown (#1866)
a9ab81b 
Fixes #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this issue Jul 15, 2023
@AlexanderYastrebov
skipper: fix shutdown test
369da3d 
* verify request is still ongoing after shutdown started
* verify shutdown completes after request is finished
* rename tests to have the ame prefix

Updates #988 #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this issue Jul 15, 2023
@AlexanderYastrebov
skipper: fix shutdown test
e50fbf5 
Make test request in parallel to ensure another request is refused
not only after shutdown started but also while shutdown is still in progress
(i.e. while test request is still in progress).

Verify shutdown completes after test request is finished.

Rename tests to have the same prefix.

Updates #988 #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this issue Jul 15, 2023
@AlexanderYastrebov
skipper: fix shutdown test
5499ba7 
Make test request in parallel to ensure another request is refused
not only after shutdown started but also while shutdown is still in progress
(i.e. while test request is still in progress).

Verify shutdown completes after test request is finished.

Rename tests to have the same prefix.

Updates #988 #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
@AlexanderYastrebov AlexanderYastrebov mentioned this issue Jul 15, 2023
Merged
AlexanderYastrebov added a commit that referenced this issue Jul 15, 2023
@AlexanderYastrebov
skipper: fix shutdown test
c552645 
Make test request in parallel to ensure another request is refused
not only after shutdown started but also while shutdown is still in progress
(i.e. while test request is still in progress).

Verify shutdown completes after test request is finished.

Rename tests to have the same prefix.

Updates #988 #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov added a commit that referenced this issue Jul 24, 2023
@AlexanderYastrebov
skipper: fix shutdown test (#2462)
1817eda 
Make test request in parallel to ensure another request is refused
not only after shutdown started but also while shutdown is still in progress
(i.e. while test request is still in progress).

Verify shutdown completes after test request is finished.

Rename tests to have the same prefix.

Updates #988 #1865

Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderYastrebov AlexanderYastrebov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements HTTPS graceful shutdown zalando/skipper
1 participant
@AlexanderYastrebov