change in the strategy to report instances #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
jmcs
approved these changes
Oct 26, 2018
|
👍 |
jmcs
pushed a commit
that referenced
this pull request
Nov 29, 2018
Change in the strategy to report instance status following the same pragmatic approach as #547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change seems to be enough to allow reporting instances managed by Elastigroups.
Only AWS can set
aws:prefixed tags. Instances created by the Elastigroups don't have theaws:cloudformation:stack-nametag that was used to filter instances.Pragmatically, I believe that the
Nametag contains exactly the same information, although the guarantee that it was created by CloudFormation no longer exists.If this new approach doesn't sound reasonable, please share the particular uses cases or assumptions where this change will break.
This also changed the instance state filtering to the server side for some micro optimization.
This updates #517