Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Elastigroup for all commands #517

Open
lmineiro opened this issue Jul 11, 2018 · 8 comments
Open

Support Elastigroup for all commands #517

lmineiro opened this issue Jul 11, 2018 · 8 comments

Comments

@lmineiro
Copy link
Contributor

lmineiro commented Jul 11, 2018

Some command line options don't work with Spotinst Elastigroups, only native Auto Scaling Groups.

The commands that seem to work:

The commands that still don't work or don't offer Elastigroup:

  • init - no knowledge about Elastigroups
@lmineiro lmineiro changed the title Add support Elastigroup for all commands Support Elastigroup for all commands Jul 12, 2018
jmcs pushed a commit that referenced this issue Jul 20, 2018
@pc-alves
Copy link
Collaborator

Scale updated to support Elastigroup

@dmytro-vynokurov
Copy link

@lmineiro @pc-alves are there any plans on adding support for the instances command to work with ElastiGroup?

@lmineiro
Copy link
Contributor Author

The current workaround is to use the --all flag and grep for your specific application. For example:

senza instances --all | grep myapp

Hopefully gives you the same as:

senza instances myapp

This will eventually be implemented, but since there's a reasonable workaround it doesn't have a high priority currently

@dmytro-vynokurov
Copy link

@lmineiro thanks for answering. Reason why I'm asking is that the workaround you mentioned sometimes is quite slow. It takes up to 20sec to run senza instances --all when running from office network and one of my colleagues noticed this time to grow up to 40sec when running from home. At the same time running senza inst $APPLICATION never takes longer than a couple of seconds.

@lmineiro
Copy link
Contributor Author

lmineiro commented Oct 25, 2018

According to my own experiments, the time the command takes, even without --all, varies a lot and can be very slow at times.

My test using the stack reference:

$ time senza instances skipper
Stack Name│Ver.│Resource ID│Instance ID        │Public IP     │Private IP   │State  │LB Status│Launched
<28 instances listed>
real	0m23.177s
user	0m2.429s
sys	0m0.265s

Followed almost immediately by the same query with --all

$ time senza instances skipper --all
Stack Name│Ver.│Resource ID│Instance ID        │Public IP     │Private IP   │State  │LB Status│Launched
<the same 28 instances listed>
real	0m15.200s
user	0m2.342s
sys	0m0.244s

As you can see, both are very slow, and using the stack reference was even slower for me.

The proposed workaround is exactly that - just a workaround until we're confident that something like #547 is an acceptable solution.

@dmytro-vynokurov
Copy link

@lmineiro thank you for the explanation. Then I guess we'll stick to the workaround until senza gets updated

@lmineiro
Copy link
Contributor Author

@dmytro-vynokurov please update senza to latest (2.1.130) and try it out

@dmytro-vynokurov
Copy link

@lmineiro done. It works. Thanks a lot for implementing this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants