Snap to non-fractioned scaling boundaries #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Trosien <[email protected]>
golangcibot
reviewed
May 5, 2019
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
|
👍 |
mikkeloscar
reviewed
May 6, 2019
operator/autoscaler.go
Outdated
| @@ -293,7 +293,9 @@ func (as *AutoScaler) scaleUpOrDown(esIndices map[string]ESIndex, scalingHint Sc | |||
| } | |||
| } | |||
|
|
|||
| newDesiredNodeReplicas := as.ensureUpperBoundNodeReplicas(scalingSpec, int32(math.Ceil(float64(currentTotalShards)/float64(currentShardToNodeRatio-1)))) | |||
| // round down to the next non-fractioned shard-to-node ratio | |||
| newShardToNodeRatio := math.Ceil(float64(currentTotalShards) / math.Floor(currentShardToNodeRatio-0.00001)) | |||
There was a problem hiding this comment.
This seems a little hacky, what is the reason for this particular fraction? :)
There was a problem hiding this comment.
just getting the code to round down. Too much magic? Shall I extract this into a private method and add more tests?
There was a problem hiding this comment.
I added more tests... WDYT?
golangcibot
reviewed
May 6, 2019
Signed-off-by: Oliver Trosien <[email protected]>
otrosien
force-pushed
the
non-fractioned-scaling
branch
from
bdb22a9
to
91ed120
Compare
Signed-off-by: Oliver Trosien <[email protected]>
|
👍 |
|
adressed some of the review comments. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59