-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticsearch 7.0 support #44
Conversation
863627d
to
774a5a9
Compare
2c5aab3
to
8b03892
Compare
Question: should we parametrize and run all e2e tests with both versions? To me at least the scaling part would be interesting as it includes some more calls to the ES APIs. |
spec: | ||
serviceAccountName: operator | ||
securityContext: | ||
fsGroup: 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of setting fsGroup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
took this from the Elasticsearch helm chart. Not sure if it's needed, but it also shouldn't hurt. https://github.com/elastic/helm-charts/blob/master/elasticsearch/templates/statefulset.yaml#L49
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know why they put "runAsUser: 0" and "privileged: true" btw. https://github.com/elastic/helm-charts/blob/master/elasticsearch/templates/statefulset.yaml#L110
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about I add fsGroup: 1000 consistently in all the manifests?
It seems like the e2e tests are failing |
Hm.. I'll rebase this ontop of #60 once it's merged. Right now the scaling boundaries are not 100% correct. |
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
I don't get the reason for the flaky e2e tests... |
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Oliver Trosien <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
👍 |
1 similar comment
👍 |
👍 |
Elasticsearch 7.0 support - no changes in ES Operator itself required.
Notable changes:
Closes #41