Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch 7.0 support #44

Merged
merged 14 commits into from
May 14, 2019
Merged

Elasticsearch 7.0 support #44

merged 14 commits into from
May 14, 2019

Conversation

otrosien
Copy link
Member

@otrosien otrosien commented Apr 27, 2019 •
edited
Loading

Elasticsearch 7.0 support - no changes in ES Operator itself required.

Notable changes:

  • Cluster Bootstrapping changed, this requires ES Masters to become a StatefulSet instead of Deployment

Closes #41

@otrosien otrosien mentioned this pull request Apr 27, 2019
Closed
@otrosien otrosien changed the title Test ES 7.0 support Elasticsearch 7.0 support Apr 28, 2019
golangcibot
golangcibot reviewed May 6, 2019
View reviewed changes
cmd/e2e/test_utils.go Outdated Show resolved Hide resolved
@otrosien otrosien force-pushed the es7 branch 3 times, most recently from 2c5aab3 to 8b03892 Compare May 6, 2019 09:00
@otrosien
Copy link
Member Author

otrosien commented May 6, 2019 •
edited
Loading

Question: should we parametrize and run all e2e tests with both versions? To me at least the scaling part would be interesting as it includes some more calls to the ES APIs.

njuettner
njuettner reviewed May 6, 2019
View reviewed changes
deploy/e2e/apply/es6-master.yaml
spec:
serviceAccountName: operator
securityContext:
fsGroup: 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of setting fsGroup?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took this from the Elasticsearch helm chart. Not sure if it's needed, but it also shouldn't hurt. https://github.com/elastic/helm-charts/blob/master/elasticsearch/templates/statefulset.yaml#L49

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why they put "runAsUser: 0" and "privileged: true" btw. https://github.com/elastic/helm-charts/blob/master/elasticsearch/templates/statefulset.yaml#L110

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about I add fsGroup: 1000 consistently in all the manifests?

@njuettner
Copy link
Contributor

It seems like the e2e tests are failing
replicas 3 != expected 2

@otrosien
Copy link
Member Author

otrosien commented May 6, 2019

Hm.. I'll rebase this ontop of #60 once it's merged. Right now the scaling boundaries are not 100% correct.

@otrosien otrosien added this to the v0.2.0 milestone May 6, 2019
@otrosien otrosien added the work in progress Work in progress label May 6, 2019
@otrosien
Elasticsearch 7.0 support
e49575f 
Signed-off-by: Oliver Trosien <[email protected]>
@otrosien
ES 7 API changes
e5c2199 
Signed-off-by: Oliver Trosien <[email protected]>
@otrosien
Align e2e test from CDP with e2e from docs
c6070b4 
Signed-off-by: Oliver Trosien <[email protected]>
@otrosien
Test both ES6 and ES7
e55eb9e 
Signed-off-by: Oliver Trosien <[email protected]>
@otrosien
Clean up
c94d508 
Signed-off-by: Oliver Trosien <[email protected]>
@otrosien
Parametrize scaling test
2dc303e 
Signed-off-by: Oliver Trosien <[email protected]>
@otrosien
Fix e2e test
bffb73d 
Signed-off-by: Oliver Trosien <[email protected]>
@otrosien
Debug e2e test
eb13b98 
Signed-off-by: Oliver Trosien <[email protected]>
@otrosien
more debugging
ea7251e 
Signed-off-by: Oliver Trosien <[email protected]>
golangcibot
golangcibot reviewed May 7, 2019
View reviewed changes
cmd/e2e/test_utils.go Outdated Show resolved Hide resolved
@otrosien
remove some debug
d72a9a0 
Signed-off-by: Oliver Trosien <[email protected]>
@otrosien
Copy link
Member Author

otrosien commented May 7, 2019

I don't get the reason for the flaky e2e tests...

@otrosien otrosien requested a review from njuettner May 7, 2019 21:11
@otrosien otrosien removed work in progress Work in progress labels May 7, 2019
otrosien and others added 4 commits May 8, 2019 10:11
@mikkeloscar
Copy link
Collaborator

👍

1 similar comment
@rimusz
Copy link

rimusz commented May 14, 2019

👍

@otrosien otrosien merged commit 0d09da3 into master May 14, 2019
@otrosien otrosien deleted the es7 branch May 14, 2019 13:58
@otrosien
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@mikkeloscar mikkeloscar Awaiting requested review from mikkeloscar mikkeloscar is a code owner

@njuettner njuettner Awaiting requested review from njuettner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Elasticsearch v7.0 support
5 participants
@otrosien @njuettner @mikkeloscar @rimusz @golangcibot