feat(plugins): Switch from /plugin-manifest.js to /plugin-manifest.js…

…on (spinnaker#7905)

BREAKING CHANGE: Switch plugin-manifest to json to match the json output from gate's /plugins/deck/plugin-manifest.json

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

app/scripts/modules/core/src/plugins/plugin.registry.spec.ts

@@ -2,6 +2,7 @@ import { IStageTypeConfig } from 'core/domain';
 import { API } from '../api';
 import { IDeckPlugin, IPluginManifest, IPluginMetaData, PluginRegistry } from './plugin.registry';
 import { Registry } from 'core/registry';
+import { mock } from 'angular';
 
 type TestPluginRegistry = PluginRegistry & {
   load(pluginManifestData: IPluginManifest): Promise<any>;
@@ -34,11 +35,14 @@ describe('PluginRegistry', () => {
     });
   });
 
-  it('loadPluginManifestFromDeck() should import() from /plugin-manifest.js', async () => {
-    loadModuleFromUrlSpy.and.callFake(() => Promise.resolve({ plugins: [] }));
-    await pluginRegistry.loadPluginManifestFromDeck();
-    expect(loadModuleFromUrlSpy).toHaveBeenCalledWith('/plugin-manifest.js');
-  });
+  it(
+    'loadPluginManifestFromDeck() should fetch /plugin-manifest.json from deck assets',
+    mock.inject(async ($http: any) => {
+      const spy = spyOn($http, 'get').and.callFake(() => Promise.resolve({ data: [] }));
+      await pluginRegistry.loadPluginManifestFromDeck();
+      expect(spy).toHaveBeenCalledWith('/plugin-manifest.json');
+    }),
+  );
 
   it('loadPluginManifestFromGate() should fetch from gate /plugins/deck/plugin-manifest.json', async () => {
     const spy = jasmine.createSpy('get', () => Promise.resolve([])).and.callThrough();

app/scripts/modules/core/src/plugins/plugin.registry.ts

@@ -1,6 +1,7 @@
 import { API } from 'core/api';
 import { Registry } from 'core/registry';
 import { IStageTypeConfig } from 'core/domain';
+import { $http } from 'ngimport';
 
 export interface IDeckPlugin {
   stages?: IStageTypeConfig[];
@@ -91,15 +92,10 @@ export class PluginRegistry {
   /** Loads plugin manifest file served as a custom deck asset */
   public loadPluginManifestFromDeck() {
     const source = 'deck';
-    const uri = '/plugin-manifest.js';
-    const loadPromise = this.loadModuleFromUrl(uri)
-      .then((pluginManifest: IPluginManifest) => {
-        if (!pluginManifest || !pluginManifest.plugins) {
-          throw new Error(`Expected plugin-manifest.js to contain an export named 'plugins' but it did not.`);
-        }
-        return pluginManifest.plugins;
-      })
-      .catch(error => {
+    const uri = '/plugin-manifest.json';
+    const loadPromise = Promise.resolve($http.get<IPluginMetaData[]>(uri))
+      .then(response => response.data)
+      .catch((error: any) => {
         console.error(`Failed to load ${uri} from ${source}`);
         throw error;
       });

plugin-manifest.json

@@ -0,0 +1 @@
+[]

webpack.config.js

@@ -194,8 +194,8 @@ function configure(env, webpackOpts) {
           to: `./styleguide.html`,
         },
         {
-          from: `./plugin-manifest.js`,
-          to: `./plugin-manifest.js`,
+          from: `./plugin-manifest.json`,
+          to: `./plugin-manifest.json`,
         },
       ]),
       new HtmlWebpackPlugin({