Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): Switch from /plugin-manifest.js to /plugin-manifest.json #7905

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

christopherthielen
Copy link
Contributor

@christopherthielen christopherthielen commented Feb 17, 2020

BREAKING CHANGE: Migrate the deck plugin-manifest asset from .js to .json to match the json output from gate's /plugins/deck/plugin-manifest.json

BREAKING CHANGE: Switch plugin-manifest to json to match the json output from gate's /plugins/deck/plugin-manifest.json
@christopherthielen
Copy link
Contributor Author

@bpowell

@christopherthielen
Copy link
Contributor Author

@bpowell @link108 ptal

@christopherthielen christopherthielen added ready to merge Reviewed and ready for merge self merge labels Feb 24, 2020
@mergify mergify bot merged commit dba6bf1 into spinnaker:master Feb 24, 2020
plumpy added a commit that referenced this pull request Feb 24, 2020
mergify bot pushed a commit that referenced this pull request Feb 24, 2020
christopherthielen pushed a commit to christopherthielen/deck that referenced this pull request Feb 24, 2020
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Feb 25, 2020
…on (spinnaker#7905)

BREAKING CHANGE: Switch plugin-manifest to json to match the json output from gate's /plugins/deck/plugin-manifest.json

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Feb 27, 2020
…on (#7905) (#7950)

BREAKING CHANGE: Switch plugin-manifest to json to match the json output from gate's /plugins/deck/plugin-manifest.json

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
…on (spinnaker#7905)

BREAKING CHANGE: Switch plugin-manifest to json to match the json output from gate's /plugins/deck/plugin-manifest.json

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
…on (spinnaker#7905) (spinnaker#7950)

BREAKING CHANGE: Switch plugin-manifest to json to match the json output from gate's /plugins/deck/plugin-manifest.json

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants