Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minor version on driver and increase the current firmware version #289

Closed
corot opened this issue Aug 29, 2013 · 5 comments
Closed

Comments

@corot
Copy link
Collaborator

corot commented Aug 29, 2013

Due to issue #249.

CURRENT_FIRMWARE_MINOR_VERSION changes to 2.

This will make a warning log advising to update firmware at driver startup.

@corot
Copy link
Collaborator Author

corot commented Aug 29, 2013

Confirm that issue #249 is ok....

@stonier
Copy link
Member

stonier commented Aug 29, 2013

Just confirming...

This will advise on startup but not stop the program (i.e. just ROS_INFO/ROS_WARN or something?).

Was this the behaviour of existing code?

@corot
Copy link
Collaborator Author

corot commented Aug 29, 2013

As you said, you will see this warning:

sig_warn.emit("Robot firmware is outdated; we suggest you to upgrade it " \
                      "to benefit from the latest features. Consult how-to on: "  \
                      "http://kobuki.yujinrobot.com/documentation/howtos/upgrading-firmware");

@corot
Copy link
Collaborator Author

corot commented Aug 29, 2013

But I will add an specific message in case you call set/get PID methods

@stonier
Copy link
Member

stonier commented Aug 29, 2013

Ah...we did good!

@corot corot closed this as completed Aug 30, 2013
@jakan2 jakan2 assigned yhju and unassigned corot Mar 19, 2014
@jakan2 jakan2 assigned jakan2 and yhju and unassigned yhju and jakan2 Mar 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants