[#6540] Platform: Remove certificate feature. #6885

mahendranbhat · 2021-01-15T11:31:49Z

Description: Remove certificate feature which will be added in the list view of certificates to delete unused certificates.
If the certificate is linked to the existing universe then we will be disabling the button in the FE.

Testing: :

Go to certificates
Try to delete the certificate which is not linked to any universe.
Also we can not see the delete option for certs which is linked to the universe.

sbt run

[info] Passed: Total 1186, Failed 0, Errors 0, Passed 1182, Skipped 4

…e-db into 6540-Remove-Certificate

CLAassistant · 2021-01-15T11:31:54Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ gaurav061
✅ mahendranbhat
❌ mahendra bhat

mahendra bhat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Arnav15

Another thing, we use the google style guide for code formatting, which means line breaks need atleast a 4 space indentation

managed/src/main/java/com/yugabyte/yw/controllers/CertificateController.java

Arnav15

Also, it is important to correctly add the description as I had mentioned earlier.
Add the sections:
Description:
Testing: How you tested it, and the summary lines of the sbt test command. Should look like:

[info] Passed: Total 1115, Failed 0, Errors 0, Passed 1111, Skipped 4

sshev

need some refinements on UI side

managed/ui/src/components/certificates/Certificates.js

managed/src/main/java/com/yugabyte/yw/controllers/CertificateController.java

managed/src/main/resources/v1.routes

…gabyte-db into 6540-Remove-Certificate

Arnav15

Looks good, just these minor fixes and then it should be good to go.

Arnav15 · 2021-01-29T14:11:24Z

managed/src/main/java/com/yugabyte/yw/controllers/CertificateController.java

@@ -145,9 +146,29 @@ public Result get(UUID customerUUID, String label) {
    }
  }

+  public Result delete(UUID customerUUID, UUID reqCertUUID) {


Add a check to verify the certificate belongs to the customer.

Arnav15 · 2021-01-29T14:13:13Z

managed/src/main/java/com/yugabyte/yw/models/Universe.java

+
+  public static boolean existsCertificate(UUID certUUID, UUID customerUUID) {
+    Set<Universe> universeList = Customer.get(customerUUID).getUniverses();
+    for (Universe universe : universeList) {


Nit: Maybe use the java stream functionality. (If unaware, take a look here)

…40-Remove-Certificate

managed/src/main/java/com/yugabyte/yw/controllers/CertificateController.java

…40-Remove-Certificate

* certificate delete api * added one field to response * added removable * [6540] Added ability to delete certificates * added removable field * removable added * removable added to list api * [6540]Added ability to remove certificate * added validation for remove certificates. * review comment fixes * replaced removable props with inUse as recommended * fixed disabled scenario of remove cert button * review comment fixes * Addressed review comments * modified test cases * Code improvements * modified FE code as recommended * removed local state declaration * Review comment fixes * review comment fixes * review comment fixes * review comment fixes * review comment fixes * certificate delete api * added one field to response * added removable * [6540] Added ability to delete certificates * added removable field * removable added * [6540]Added ability to remove certificate * removable added to list api * added validation for remove certificates. * review comment fixes * replaced removable props with inUse as recommended * fixed disabled scenario of remove cert button * review comment fixes * Addressed review comments * modified test cases * Code improvements * modified FE code as recommended * removed local state declaration * Review comment fixes * review comment fixes * review comment fixes * review comment fixes * review comment fixes * review comment fixes * Review comment fixes * Review comment fixes Co-authored-by: mahendra bhat <[email protected]> Co-authored-by: gaurav061 <[email protected]>

mahendra bhat and others added 13 commits December 22, 2020 16:39

certificate delete api

94689c3

added one field to response

65a602d

added removable

e464767

[6540] Added ability to delete certificates

6512997

added removable field

9768123

removable added

502284e

removable added to list api

e25b46b

[6540]Added ability to remove certificate

c725549

Merge branch '6540-Remove-Certificate' of github.com:yugabyte/yugabyt…

602d7bc

…e-db into 6540-Remove-Certificate

added validation for remove certificates.

46447f9

review comment fixes

f28d865

replaced removable props with inUse as recommended

211b4fe

fixed disabled scenario of remove cert button

349c231

Arnav15 suggested changes Jan 16, 2021

View reviewed changes

managed/src/main/java/com/yugabyte/yw/controllers/CertificateController.java Outdated Show resolved Hide resolved

review comment fixes

e9735ab

mahendranbhat requested a review from Arnav15 January 16, 2021 13:26

Arnav15 suggested changes Jan 16, 2021

View reviewed changes

tylarb mentioned this pull request Jan 20, 2021

[#6540] Platform: Remove certificate feature. #6767

Closed

sshev requested changes Jan 21, 2021

View reviewed changes

daniel-yb reviewed Jan 21, 2021

View reviewed changes

managed/src/main/java/com/yugabyte/yw/controllers/CertificateController.java Outdated Show resolved Hide resolved

daniel-yb reviewed Jan 21, 2021

View reviewed changes

managed/src/main/java/com/yugabyte/yw/controllers/CertificateController.java Outdated Show resolved Hide resolved

daniel-yb reviewed Jan 21, 2021

View reviewed changes

managed/src/main/java/com/yugabyte/yw/controllers/CertificateController.java Outdated Show resolved Hide resolved

daniel-yb reviewed Jan 21, 2021

View reviewed changes

managed/src/main/resources/v1.routes Outdated Show resolved Hide resolved

mahendranbhat marked this pull request as draft January 22, 2021 05:43

mahendranbhat changed the title ~~[#6540] Platform: Remove certificate feature.~~ [#6540] [WIP] Platform: Remove certificate feature. Jan 22, 2021

mahendra bhat and others added 4 commits January 26, 2021 19:11

Addressed review comments

43eaf61

modified test cases

194aed1

Code improvements

ed43e8f

modified FE code as recommended

21f7577

mahendra bhat and others added 16 commits January 28, 2021 19:52

review comment fixes

edeb916

replaced removable props with inUse as recommended

d3a4545

fixed disabled scenario of remove cert button

e4dad01

review comment fixes

562ea49

Addressed review comments

e10b4db

modified test cases

75e7186

Code improvements

54fb9d2

modified FE code as recommended

3ce3266

removed local state declaration

b3639e2

Review comment fixes

6c4ac42

review comment fixes

e7935df

review comment fixes

57917c1

review comment fixes

78affc1

review comment fixes

95f61ba

Merge branch '6540-Remove-Certificate' of github.com:jaydeepkumara/yu…

70503bb

…gabyte-db into 6540-Remove-Certificate

merge conflict resolved

2515807

Arnav15 suggested changes Jan 29, 2021

View reviewed changes

mahendra bhat added 2 commits February 2, 2021 18:06

review comment fixes

bf6fe93

Review comment fixes

850bcef

mahendranbhat changed the title ~~[#6540] [WIP] Platform: Remove certificate feature.~~ [#6540] Platform: Remove certificate feature. Feb 2, 2021

mahendranbhat linked an issue Feb 2, 2021 that may be closed by this pull request

Add ability to remove certificates from UI #6540

Closed

mahendranbhat requested a review from Arnav15 February 2, 2021 12:56

gaurav061 and others added 2 commits February 2, 2021 19:15

Modified api to accomodate customer uuid

e311a2b

Merge branch 'master' of github.com:jaydeepkumara/yugabyte-db into 65…

9fcd78d

…40-Remove-Certificate

mahendranbhat marked this pull request as ready for review February 9, 2021 05:39

Arnav15 approved these changes Feb 10, 2021

View reviewed changes

managed/src/main/java/com/yugabyte/yw/controllers/CertificateController.java Outdated Show resolved Hide resolved

mahendranbhat added 2 commits February 10, 2021 20:16

Review comment fixes

dc48062

Merge branch 'master' of github.com:jaydeepkumara/yugabyte-db into 65…

750ef97

…40-Remove-Certificate

gaurav061 merged commit 74bf17e into yugabyte:master Feb 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#6540] Platform: Remove certificate feature. #6885

[#6540] Platform: Remove certificate feature. #6885

mahendranbhat commented Jan 15, 2021 •

edited

Loading

CLAassistant commented Jan 15, 2021 •

edited

Loading

Arnav15 left a comment

Arnav15 left a comment

sshev left a comment

Arnav15 left a comment

Arnav15 Jan 29, 2021

Arnav15 Jan 29, 2021

[#6540] Platform: Remove certificate feature. #6885

[#6540] Platform: Remove certificate feature. #6885

Conversation

mahendranbhat commented Jan 15, 2021 • edited Loading

CLAassistant commented Jan 15, 2021 • edited Loading

Arnav15 left a comment

Choose a reason for hiding this comment

Arnav15 left a comment

Choose a reason for hiding this comment

sshev left a comment

Choose a reason for hiding this comment

Arnav15 left a comment

Choose a reason for hiding this comment

Arnav15 Jan 29, 2021

Choose a reason for hiding this comment

Arnav15 Jan 29, 2021

Choose a reason for hiding this comment

mahendranbhat commented Jan 15, 2021 •

edited

Loading

CLAassistant commented Jan 15, 2021 •

edited

Loading