Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to remove certificates from UI #6540

Closed
tylarb opened this issue Dec 3, 2020 · 0 comments · Fixed by #6885
Closed

Add ability to remove certificates from UI #6540

tylarb opened this issue Dec 3, 2020 · 0 comments · Fixed by #6885
Assignees
Labels
area/platform Yugabyte Platform team/platform-hi Tickets handled by HashedIn team
Milestone

Comments

@tylarb
Copy link
Contributor

tylarb commented Dec 3, 2020

Currently all certificates which have ever been created remain visible in Yugaware.

It would be nice to have a button that will allow you to delete wrongs/expired certificates etc., from the Yugaware platform.

@tylarb tylarb added the area/platform Yugabyte Platform label Dec 3, 2020
@streddy-yb streddy-yb added the team/platform-hi Tickets handled by HashedIn team label Dec 7, 2020
@streddy-yb streddy-yb added this to the 2.5.x milestone Dec 8, 2020
@mahendranbhat mahendranbhat linked a pull request Feb 2, 2021 that will close this issue
@yugabyte yugabyte deleted a comment from gaurav061 Feb 2, 2021
gaurav061 added a commit that referenced this issue Feb 11, 2021
* certificate delete api

* added one field to response

* added removable

* [6540] Added ability to delete certificates

* added removable field

* removable added

* removable added to list api

* [6540]Added ability to remove certificate

* added validation for remove certificates.

* review comment fixes

* replaced removable props with inUse as recommended

* fixed disabled scenario of remove cert button

* review comment fixes

* Addressed review comments

* modified test cases

* Code improvements

* modified FE code as recommended

* removed local state declaration

* Review comment fixes

* review comment fixes

* review comment fixes

* review comment fixes

* review comment fixes

* certificate delete api

* added one field to response

* added removable

* [6540] Added ability to delete certificates

* added removable field

* removable added

* [6540]Added ability to remove certificate

* removable added to list api

* added validation for remove certificates.

* review comment fixes

* replaced removable props with inUse as recommended

* fixed disabled scenario of remove cert button

* review comment fixes

* Addressed review comments

* modified test cases

* Code improvements

* modified FE code as recommended

* removed local state declaration

* Review comment fixes

* review comment fixes

* review comment fixes

* review comment fixes

* review comment fixes

* review comment fixes

* Review comment fixes

* Review comment fixes

Co-authored-by: mahendra bhat <[email protected]>
Co-authored-by: gaurav061 <[email protected]>
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this issue Mar 9, 2021
* certificate delete api

* added one field to response

* added removable

* [6540] Added ability to delete certificates

* added removable field

* removable added

* removable added to list api

* [6540]Added ability to remove certificate

* added validation for remove certificates.

* review comment fixes

* replaced removable props with inUse as recommended

* fixed disabled scenario of remove cert button

* review comment fixes

* Addressed review comments

* modified test cases

* Code improvements

* modified FE code as recommended

* removed local state declaration

* Review comment fixes

* review comment fixes

* review comment fixes

* review comment fixes

* review comment fixes

* certificate delete api

* added one field to response

* added removable

* [6540] Added ability to delete certificates

* added removable field

* removable added

* [6540]Added ability to remove certificate

* removable added to list api

* added validation for remove certificates.

* review comment fixes

* replaced removable props with inUse as recommended

* fixed disabled scenario of remove cert button

* review comment fixes

* Addressed review comments

* modified test cases

* Code improvements

* modified FE code as recommended

* removed local state declaration

* Review comment fixes

* review comment fixes

* review comment fixes

* review comment fixes

* review comment fixes

* review comment fixes

* Review comment fixes

* Review comment fixes

Co-authored-by: mahendra bhat <[email protected]>
Co-authored-by: gaurav061 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Yugabyte Platform team/platform-hi Tickets handled by HashedIn team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@tylarb @mahendranbhat @gaurav061 @chirag-yb @streddy-yb and others