Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Changing node filter for universe metrics does not update the graphs #7107

Closed
andrewc-dev opened this issue Feb 4, 2021 · 1 comment
Closed

[Platform] Changing node filter for universe metrics does not update the graphs #7107

andrewc-dev opened this issue Feb 4, 2021 · 1 comment
Assignees
@sunilsutarDCE
Labels
area/platform Yugabyte Platform area/ui All issues relating to UI/UX

Comments

@andrewc-dev
Copy link
Contributor

andrewc-dev commented Feb 4, 2021 •
edited
Loading

On universe -> Metrics tab, when changing the node filter from 'All' to a specific nodes, then back. Sometimes the graph will not re-plot even though the data is different.
EDIT: Seen on version 2.5.2
@andrewc-dev andrewc-dev added area/ui All issues relating to UI/UX area/platform Yugabyte Platform labels Feb 4, 2021
@tylarb
Copy link
Contributor

tylarb commented Feb 10, 2021

This issue also affects 2.4.0

@sunilsutarDCE sunilsutarDCE self-assigned this Feb 15, 2021
sunilsutarDCE added a commit that referenced this issue Feb 18, 2021
@sunilsutarDCE
[Platform][#7107] Changing node filter for universe metrics does not …
af186f6 
…update the graphs

Summary:
1) On universe -> Metrics tab, when changing the node filter from 'All' to a specific nodes, then back. Sometimes the graph will not re-plot even though the data is different. There was a condition added to prevent re-plotting of graph for time on componentDidUpdate lifecycle method , but need to check values as well when node changed . So deep comparing on the x-axis and y-axis data arrays.
2) While testing also found that - when node select it was not showing as selected in dropdown, currentSelectedNode state was not updated when node dropdown changed .

Test Plan:
- Run UI
- Go to Metrics navigation link at left side or universe -> Metrics tab
- Try changing Universe and selecting node .
- Checked manually by debugging in google developers tool for re-plotting graph

Reviewers: mjoshi, andrew

Reviewed By: andrew

Subscribers: sshevchenko, ui, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D10629
@sunilsutarDCE sunilsutarDCE mentioned this issue Feb 18, 2021
Closed
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this issue Mar 9, 2021
@sunilsutarDCE
[Platform][yugabyte#7107] Changing node filter for universe metrics d…
84f4a69 
…oes not update the graphs

Summary:
1) On universe -> Metrics tab, when changing the node filter from 'All' to a specific nodes, then back. Sometimes the graph will not re-plot even though the data is different. There was a condition added to prevent re-plotting of graph for time on componentDidUpdate lifecycle method , but need to check values as well when node changed . So deep comparing on the x-axis and y-axis data arrays.
2) While testing also found that - when node select it was not showing as selected in dropdown, currentSelectedNode state was not updated when node dropdown changed .

Test Plan:
- Run UI
- Go to Metrics navigation link at left side or universe -> Metrics tab
- Try changing Universe and selecting node .
- Checked manually by debugging in google developers tool for re-plotting graph

Reviewers: mjoshi, andrew

Reviewed By: andrew

Subscribers: sshevchenko, ui, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D10629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunilsutarDCE sunilsutarDCE

Labels
area/platform Yugabyte Platform area/ui All issues relating to UI/UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tylarb @sunilsutarDCE @andrewc-dev