Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Platform][#7107] Changing node filter for universe metrics does not …
…update the graphs Summary: 1) On universe -> Metrics tab, when changing the node filter from 'All' to a specific nodes, then back. Sometimes the graph will not re-plot even though the data is different. There was a condition added to prevent re-plotting of graph for time on componentDidUpdate lifecycle method , but need to check values as well when node changed . So deep comparing on the x-axis and y-axis data arrays. 2) While testing also found that - when node select it was not showing as selected in dropdown, currentSelectedNode state was not updated when node dropdown changed . Test Plan: - Run UI - Go to Metrics navigation link at left side or universe -> Metrics tab - Try changing Universe and selecting node . - Checked manually by debugging in google developers tool for re-plotting graph Reviewers: mjoshi, andrew Reviewed By: andrew Subscribers: sshevchenko, ui, yugaware Differential Revision: https://phabricator.dev.yugabyte.com/D10629
- Loading branch information