Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnapshotTxnTest.HotRow fails in TSAN #6902

Closed
spolitov opened this issue Jan 17, 2021 · 0 comments
Closed

SnapshotTxnTest.HotRow fails in TSAN #6902

spolitov opened this issue Jan 17, 2021 · 0 comments
Assignees
@spolitov
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug

Comments

@spolitov
Copy link
Contributor

No description provided.

@spolitov spolitov added kind/bug This issue is a bug area/docdb YugabyteDB core features labels Jan 17, 2021
@spolitov spolitov self-assigned this Jan 17, 2021
spolitov added a commit that referenced this issue Jan 17, 2021
@spolitov
[#6902] Remove recently added LongOperationTracker from ThreadPool
0ec0aa4 
Summary:
Recent diff (D10220 / 8c98f6c) adds long operation tracker to ThreadPool
that is causing test failures in TSAN mode in SnapshotTxnTest.HotRow.

It happens because task stream in Log could take unlimited amount of time, since it wait 1 second for new tasks to arrive.
It could trigger long operation tracker that will dump stack trace, so test fails because some write is significally slower than the first one.

Test Plan: ybd tsan --gtest_filter SnapshotTxnTest.HotRow

Reviewers: bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D10384
@bmatican bmatican mentioned this issue Feb 24, 2021
Closed
nspiegelberg pushed a commit that referenced this issue Feb 24, 2021
@spolitov @nspiegelberg
[BACKPORT 2.4] [#6747][#7284][#7109][#6902] YCQL system.partition bug…
e76dda0 
… fixes

Summary:
A squash of 4 small commits:
    1. Don't block thread while waiting for rebuild YCQL system table cache
       Original commit: D10220 / 8df96b1530a692b7718abc04c9f7cb7409dbf2ac
    2. Disable YCQL system.partitions master side cache
       Original commit: D10647 / a02af16
    3. Fix a race in accessing the YQLPartitionsVTable::cache_ object
       Original commit: D10548 / e20a1ad
    4. Remove recently added LongOperationTracker from ThreadPool
       Original commit: D10384 / 0ec0aa4

Test Plan:
Jenkins: rebase: 2.4, hot
ybd --gtest_filter BackupTxnTest.DeleteTableWithMastersRestart -n 20
ybd tsan --gtest_filter SnapshotTxnTest.HotRow

Reviewers: zyu, sergei, rsami, rahuldesirazu, bogdan

Reviewed By: bogdan

Subscribers: ybase, zyu, dsrinivasan

Differential Revision: https://phabricator.dev.yugabyte.com/D10702
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this issue Mar 9, 2021
@spolitov
[yugabyte#6902] Remove recently added LongOperationTracker from Threa…
3ec430b 
…dPool

Summary:
Recent diff (D10220 / 8c98f6c) adds long operation tracker to ThreadPool
that is causing test failures in TSAN mode in SnapshotTxnTest.HotRow.

It happens because task stream in Log could take unlimited amount of time, since it wait 1 second for new tasks to arrive.
It could trigger long operation tracker that will dump stack trace, so test fails because some write is significally slower than the first one.

Test Plan: ybd tsan --gtest_filter SnapshotTxnTest.HotRow

Reviewers: bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D10384
@bmatican bmatican mentioned this issue Apr 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spolitov