Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BackupTxnTest.DeleteTableWithMastersRestart fails in master #6747

Closed
spolitov opened this issue Dec 24, 2020 · 1 comment
Closed

BackupTxnTest.DeleteTableWithMastersRestart fails in master #6747

spolitov opened this issue Dec 24, 2020 · 1 comment
Assignees
@spolitov
Labels
kind/bug This issue is a bug

Comments

@spolitov
Copy link
Contributor

No description provided.

@spolitov spolitov added the kind/bug This issue is a bug label Dec 24, 2020
@spolitov spolitov self-assigned this Dec 24, 2020
@spolitov
Copy link
Contributor Author

Broken by 71ed762

spolitov added a commit that referenced this issue Jan 6, 2021
@spolitov
[#6747] Don't block thread while waiting for rebuild YCQL system tabl…
8c98f6c 
…e cache

Summary:
`RebuildYQLSystemPartitions` blocks thread while waiting for rebuild interval.
It prevents master shutdown until sleep finishes.
So restarting cluster with 3 masters could take several minutes.

Fixed by replacing with wait using scheduler.

Test Plan: ybd --gtest_filter BackupTxnTest.DeleteTableWithMastersRestart -n 20

Reviewers: bogdan, zyu, nicolas

Reviewed By: zyu, nicolas

Subscribers: dsrinivasan, zyu, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D10220
spolitov added a commit that referenced this issue Jan 27, 2021
@spolitov
[#6747] Wait for master leader after restart in BackupTxnTest.DeleteT…
a6f3346 
…ableWithMastersRestart

Summary: Wait for master leader after restart in BackupTxnTest.DeleteTableWithMastersRestart

Test Plan: ybd --gtest_filter BackupTxnTest.DeleteTableWithMastersRestart -n 20

Reviewers: bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D10450
nspiegelberg pushed a commit that referenced this issue Feb 24, 2021
@spolitov @nspiegelberg
[BACKPORT 2.4] [#6747][#7284][#7109][#6902] YCQL system.partition bug…
e76dda0 
… fixes

Summary:
A squash of 4 small commits:
    1. Don't block thread while waiting for rebuild YCQL system table cache
       Original commit: D10220 / 8df96b1530a692b7718abc04c9f7cb7409dbf2ac
    2. Disable YCQL system.partitions master side cache
       Original commit: D10647 / a02af16
    3. Fix a race in accessing the YQLPartitionsVTable::cache_ object
       Original commit: D10548 / e20a1ad
    4. Remove recently added LongOperationTracker from ThreadPool
       Original commit: D10384 / 0ec0aa4

Test Plan:
Jenkins: rebase: 2.4, hot
ybd --gtest_filter BackupTxnTest.DeleteTableWithMastersRestart -n 20
ybd tsan --gtest_filter SnapshotTxnTest.HotRow

Reviewers: zyu, sergei, rsami, rahuldesirazu, bogdan

Reviewed By: bogdan

Subscribers: ybase, zyu, dsrinivasan

Differential Revision: https://phabricator.dev.yugabyte.com/D10702
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this issue Mar 9, 2021
@spolitov
[yugabyte#6747] Don't block thread while waiting for rebuild YCQL sys…
d080e25 
…tem table cache

Summary:
`RebuildYQLSystemPartitions` blocks thread while waiting for rebuild interval.
It prevents master shutdown until sleep finishes.
So restarting cluster with 3 masters could take several minutes.

Fixed by replacing with wait using scheduler.

Test Plan: ybd --gtest_filter BackupTxnTest.DeleteTableWithMastersRestart -n 20

Reviewers: bogdan, zyu, nicolas

Reviewed By: zyu, nicolas

Subscribers: dsrinivasan, zyu, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D10220
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this issue Mar 9, 2021
@spolitov
[yugabyte#6747] Wait for master leader after restart in BackupTxnTest…
11737b0 
….DeleteTableWithMastersRestart

Summary: Wait for master leader after restart in BackupTxnTest.DeleteTableWithMastersRestart

Test Plan: ybd --gtest_filter BackupTxnTest.DeleteTableWithMastersRestart -n 20

Reviewers: bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D10450
@bmatican bmatican mentioned this issue Apr 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spolitov spolitov

Labels
kind/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spolitov