Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Failing TestPgRegressIndex #24300

Closed
1 task done
sushantrmishra opened this issue Oct 6, 2024 · 0 comments
Closed
1 task done

[YSQL] Failing TestPgRegressIndex #24300

sushantrmishra opened this issue Oct 6, 2024 · 0 comments
Assignees
@timothy-e
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@sushantrmishra
Copy link

sushantrmishra commented Oct 6, 2024 •
edited by jira bot
Loading

Jira Link: DB-13189

Description

org.yb.pgsql.TestPgRegressIndex.schedule

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@sushantrmishra sushantrmishra added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Oct 6, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Oct 6, 2024
@sushantrmishra sushantrmishra removed kind/bug This issue is a bug priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage labels Oct 6, 2024
@sushantrmishra sushantrmishra mentioned this issue Oct 6, 2024
Closed
1 task
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Oct 6, 2024
timothy-e added a commit that referenced this issue Oct 15, 2024
@timothy-e
[#24300] YSQL: fix TestPgRegressIndex
ddc084d 
Summary:
Changes to several test files:
* yb_index_scan:
  * Upstream PG 1a8d5afb0dfc5d0dcc6eda0656a34cb1f0cf0bdf commutes index operators. Adjust output accordingly
* yb_index_scan_null_asc / yb_index_scan_null_hash:
  * set `jit = false` because messages about failing to find a JIT compiler appeared with pg15. I'm not sure why they appeared, it seems the lines have existed since at least PG11.
* yb_indexing_order:
  * Upstream PG 50289819230d8ddad510879ee4793b04a05cf13b  removes the logic to de-duplicate indexes on tables created with the `CREATE TABLE <name> (LIKE <other_name>)` syntax. Add back the previously de-duplicated indexes, and adjust the parent comment. This change is not explicitly mentioned in the commit summary, but I'm not sure if PG was even aware of this behaviour. There were no tests for it, and no comment stating that's what happens. But checking out YB PG11, and applying the PG11 version of the above commit, I can reproduce the difference.
* yb_reindex:
  * Upstream PG 55a1954da16e041f895e5c3a6abff13c5e3a4a2f (and then further modified by 6ef77cf46e81f45716ec981cb08781d426181378) introduced aliases for child tables of a partitioned table - adjust the output accordingly
  * Upstream PG a6642b3ae060976b42830b7dc8f29ec190ab05e4 supports reindexing partitioned indexes. In YB, this requires all child partitions to have `indisvalid` set to false. Update the test to cover some of these cases.

Also, add back support for `YB_DISABLE_ERROR_PREFIX` in roughly the same manner that it was added in YB 05ea20d. It was removed by the pg15 initial merge 55782d5.
Jira: DB-13189

Test Plan:
```lang=sh
./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressIndex'

grep "TestPgRegressIndex" pg15_tests/passing_tests.tsv | pg15_tests/run_tests.sh
```

Reviewers: jason, myang

Reviewed By: myang

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D38011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothy-e timothy-e

Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sushantrmishra @yugabyte-ci @timothy-e