Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Build broken due to compile error in lwproto-test.cc #23828

Closed
1 task done
es1024 opened this issue Sep 6, 2024 · 0 comments
Closed
1 task done

[DocDB] Build broken due to compile error in lwproto-test.cc #23828

es1024 opened this issue Sep 6, 2024 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@es1024
Copy link
Contributor

es1024 commented Sep 6, 2024

Jira Link: DB-12730

Description

a28b3ec changed protobuf_message_total_bytes_limit to uint32, but a new declaration was added in lwproto-test.cc between test run and land, causing the following compile error:

[2024-09-06T21:57:51.729Z] ld.lld: error: undefined symbol: fLI::FLAGS_protobuf_message_total_bytes_limit
[2024-09-06T21:57:51.729Z] >>> referenced by dynamic_annotations.h:686 (../../src/yb/gutil/dynamic_annotations.h:686)
[2024-09-06T21:57:51.729Z] >>>               src/yb/rpc/CMakeFiles/lwproto-test.dir/lwproto-test.cc.o:(yb::rpc::LWProtoTest_BigMessage_Test::TestBody())
[2024-09-06T21:57:51.729Z] >>> did you mean: fLU::FLAGS_protobuf_message_total_bytes_limit
[2024-09-06T21:57:51.729Z] >>> defined in: lib/libyb_util.so
[2024-09-06T21:57:51.729Z] clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@es1024 es1024 added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Sep 6, 2024
@es1024 es1024 self-assigned this Sep 6, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Sep 6, 2024
es1024 added a commit that referenced this issue Sep 7, 2024
Summary:
D37548 / a28b3ec changed protobuf_message_total_bytes_limit to uint32, but a new declaration was added in lwproto-test.cc between test run and land, causing the following compile error:
```
[2024-09-06T21:57:51.729Z] ld.lld: error: undefined symbol: fLI::FLAGS_protobuf_message_total_bytes_limit
[2024-09-06T21:57:51.729Z] >>> referenced by dynamic_annotations.h:686 (../../src/yb/gutil/dynamic_annotations.h:686)
[2024-09-06T21:57:51.729Z] >>>               src/yb/rpc/CMakeFiles/lwproto-test.dir/lwproto-test.cc.o:(yb::rpc::LWProtoTest_BigMessage_Test::TestBody())
[2024-09-06T21:57:51.729Z] >>> did you mean: fLU::FLAGS_protobuf_message_total_bytes_limit
[2024-09-06T21:57:51.729Z] >>> defined in: lib/libyb_util.so
[2024-09-06T21:57:51.729Z] clang++: error: linker command failed with exit code 1 (use -v to see invocation)
```

This diff fixes the compile error.
Jira: DB-12730

Test Plan: Jenkins: urgent, compile only

Reviewers: hsunder

Reviewed By: hsunder

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D37869
@es1024 es1024 closed this as completed Sep 9, 2024
jasonyb pushed a commit that referenced this issue Sep 9, 2024
Summary:
 82bca83 [DOC-453] ASH wait event table updates for 2.21.1 (#23595)
 011830f [PLAT-14809][YBA CLI]Support Master Key Rotation
 bd39e84 [PLAT-15088] Add DB version check for connection pooling
 9853daf [PLAT-14808][YBA CLI]Support edit KMS operations
 b02f6f7 [doc][yba] KMS and expiring tokens (#23754)
 62d30d5 [PLAT-15091][PLAT-14092] Improve HA logging and backup metric
 6cc5f6a Add more documentation on allowed preview flags (#23826)
 a28b3ec [#22301] docdb: Improve handling of large responses
 bc28ee8 [#23752] DocDB: Integrating hnswlib into the vector indexing framework and hnsw_tool
 c40fff2 copy Develop changes to stable (#23812)
 bf7c0b0 [#23828] docdb: Fix compile error in lwproto-test.cc
 Excluded: 9c1cc23 [#23707] Add table name to /metrics JSON endpoint
 3de6206 [PLAT-15151]: Update autoflags based checks for xCluster/DR
 b7bc45e Revert "[PLAT-13800] skip setting imageBundle reference for YBM based clusters using machineImage"
 35add07 [PLAT-14888]: Store PITR parmas during create DR and allow users to edit them.
 3ba74e8 Fix docs for xcluster DDL flow for YCQL & onprem provider ssh user (#23827)
 981415e [#23820] DocDB: Use shared memory for executing read and write pg client queries in release
 f20edbb Moving Driver reference to Develop section (#23683)
 a3f3bfe [PLAT-15209] Do not set optimized mem & tablet split gflags for YBM
 a95dc94 [PLAT-14801] add v2 API to list YBC Gflags metadata
 06d2b8d [PLAT-15194]CLI | All outputs are returned as List instead of JSON for commands like describe
 0375a68 [#23700] CDCSDK: Perform table removal from CDC stream via background thread
 5d2a151 [#23797] YSQL: Stabilise PgExplainAnalyzeModifyTable tests when running with Connection Manager
 e62dcfd sbt Swaggergen on master to fix Uts

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Differential Revision: https://phorge.dev.yugabyte.com/D37901
@rthallamko3 rthallamko3 removed the status/awaiting-triage Issue awaiting triage label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants