Skip to content

Commit

Permalink
[#23828] docdb: Fix compile error in lwproto-test.cc
Browse files Browse the repository at this point in the history
Summary:
D37548 / a28b3ec changed protobuf_message_total_bytes_limit to uint32, but a new declaration was added in lwproto-test.cc between test run and land, causing the following compile error:
```
[2024-09-06T21:57:51.729Z] ld.lld: error: undefined symbol: fLI::FLAGS_protobuf_message_total_bytes_limit
[2024-09-06T21:57:51.729Z] >>> referenced by dynamic_annotations.h:686 (../../src/yb/gutil/dynamic_annotations.h:686)
[2024-09-06T21:57:51.729Z] >>>               src/yb/rpc/CMakeFiles/lwproto-test.dir/lwproto-test.cc.o:(yb::rpc::LWProtoTest_BigMessage_Test::TestBody())
[2024-09-06T21:57:51.729Z] >>> did you mean: fLU::FLAGS_protobuf_message_total_bytes_limit
[2024-09-06T21:57:51.729Z] >>> defined in: lib/libyb_util.so
[2024-09-06T21:57:51.729Z] clang++: error: linker command failed with exit code 1 (use -v to see invocation)
```

This diff fixes the compile error.
Jira: DB-12730

Test Plan: Jenkins: urgent, compile only

Reviewers: hsunder

Reviewed By: hsunder

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D37869
  • Loading branch information
es1024 committed Sep 7, 2024
1 parent c40fff2 commit bf7c0b0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/yb/rpc/lwproto-test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include "yb/util/size_literals.h"
#include "yb/util/test_macros.h"

DECLARE_int32(protobuf_message_total_bytes_limit);
DECLARE_uint32(protobuf_message_total_bytes_limit);
DECLARE_uint64(rpc_max_message_size);

namespace yb {
Expand Down

0 comments on commit bf7c0b0

Please sign in to comment.