Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unified_strdate to handle "*3rd" in date strings. #23199

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Allow unified_strdate to handle "*3rd" in date strings. #23199

merged 2 commits into from
Nov 26, 2019

Conversation

Nyaa-rlathotep
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

unified_strdate was missing "*rd" for for "3rd" and "23rd". It did have "*st", "*nd", and "*th".
Fixes #23197

@Nyaa-rlathotep Nyaa-rlathotep mentioned this pull request Nov 25, 2019
9 tasks
@dstftw
Copy link
Collaborator

dstftw commented Nov 25, 2019

Add tests.

@Nyaa-rlathotep
Copy link
Contributor Author

Roger that. Tests added, and I double-checked that the new tests failed without the first commit, and passed with it.

@dstftw dstftw merged commit 9d30c21 into ytdl-org:master Nov 26, 2019
@Nyaa-rlathotep Nyaa-rlathotep deleted the unified_strdate branch August 26, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unified_strdate returns None on dates with "3rd" and "23rd"
2 participants