Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitchute] add upload_date #23193

Merged
merged 4 commits into from
Nov 26, 2019
Merged

[bitchute] add upload_date #23193

merged 4 commits into from
Nov 26, 2019

Conversation

Nyaa-rlathotep
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Adding ability to grab "upload_date" from bitchute. Will probably fix #22990 as well.

@Nyaa-rlathotep
Copy link
Contributor Author

Nyaa-rlathotep commented Nov 24, 2019

Hold off on accepting this for the moment. Just discovered that date parsing fails on dates with "3rd" or "23rd" in them. Seems to work fine on "*th", "*1st", "*2nd", etc.

Here are some example URLs of failing ones:

(November 23rd, 2019)
https://www.bitchute.com/video/6GoIfm3Sd5cE/

(November 3rd, 2019)
https://www.bitchute.com/video/Sb9v8ax9B5rL/

I'll poke around a bit and try to figure out where the problem is.

Edit: Looks like a bug with "unified_strdate". I've submitted an issue about it over at #23197.

If you'd like, I can leave this pull request as it is and have it wait for #23197 to be fixed, or I could change this code so it removes the prefixes from the day of the month before passing it to unified_strdate if you don't want to figure out why unified_strdate is acting up. Whichever you all think is better is fine with me.

Edit 2: The issue with unified_strdate was a minor oversight with an easy fix. I've submitted a PR over at #23199. Once that one's checked over and verified and everything, this one can be checked for inclusion as well.

@dstftw dstftw merged commit 6ddd4bf into ytdl-org:master Nov 26, 2019
@Nyaa-rlathotep Nyaa-rlathotep deleted the bitchute branch August 26, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitchute --dateafter flag broken
2 participants