download squarespace escaped video embeds #21859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
dstftw
requested changes
Jul 26, 2019
galgeek
force-pushed
the
dl-escaped-embeds
branch
from
4b0e69c to
15ac8c8
Compare
galgeek
changed the title
|
Thanks, @dstftw! I've updated, finding all squarespace video embeds, and escaping before searching for video URL. I've checked using these 3 URLs: http://www.ootboxford.com/ |
dstftw
requested changes
Aug 1, 2019
|
Thanks, @dstftw! |
galgeek
force-pushed
the
dl-escaped-embeds
branch
from
afad27d to
e1137c8
Compare
|
I've verified that #21294 is still present in youtube-dl version 2019.08.13, and this PR still fixes the issue. |
dstftw
requested changes
Aug 27, 2019
youtube_dl/extractor/generic.py
Outdated
| @@ -2395,6 +2395,12 @@ def _real_extract(self, url): | |||
| # Unescaping the whole page allows to handle those cases in a generic way | |||
| webpage = compat_urllib_parse_unquote(webpage) | |||
|
|
|||
| # unescape squarespace video embeds | |||
| sqs_videos = re.findall(r'<div class="[^"]*?sqs-video-wrapper[^>]*>', webpage) | |||
There was a problem hiding this comment.
re.sub.- Regex must match any quote kinds, must allow other attributes before class.
- Add a test.
galgeek
force-pushed
the
dl-escaped-embeds
branch
from
203e04f to
ffb9bed
Compare
dstftw
requested changes
Aug 31, 2019
dstftw
requested changes
Aug 31, 2019
|
@dstftw thank you for your help with this! It's great to see the fix in master, and I learned a lot, too. |
meunierd
referenced
this pull request
in meunierd/youtube-dl
Feb 13, 2020
…s #21859, refs #21294, refs #21802)
pareronia
referenced
this pull request
in pareronia/youtube-dl
Jun 22, 2020
…s #21859, refs #21294, refs #21802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Captures videos embedded in Squarespace sites in escaped html, like the youtube embeds in Squarespace sites noted in issue #21294.
This can replace #21802 already initially reviewed by @dstftw.