Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[youtube] squarespace embeds (youtube-dl issue #21294) #21802

Closed
wants to merge 2 commits into from

Conversation

galgeek
Copy link
Contributor

@galgeek galgeek commented Jul 16, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This PR adds support for recent youtube embeds on squarespace sites—see #21294

@galgeek galgeek changed the title support recent (2019) squarespace youtube embeds (youtube-dl issue #21294) [youtube] squarespace embeds (youtube-dl issue #21294) Jul 16, 2019
@dstftw
Copy link
Collaborator

dstftw commented Jul 20, 2019

This does not scale since any video can be embedded this way not only Youtube.
What should be done is unescaping and expanding embed code in place in generic extractor. This will allow supporting any video embedded this way.

@galgeek
Copy link
Contributor Author

galgeek commented Jul 22, 2019

Thanks, @dstftw! I agree, something like what you're suggesting is a better fix.

#21859 is more like what you're thinking of, I think...

@galgeek galgeek closed this Jul 22, 2019
meunierd referenced this pull request in meunierd/youtube-dl Feb 13, 2020
pareronia referenced this pull request in pareronia/youtube-dl Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants