Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[twitter] Allow single dash to be used as username #21705

Closed
wants to merge 3 commits into from
Closed

[twitter] Allow single dash to be used as username #21705

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c07d8c5
[twitter] Allow single dash to be used as username
Lesmiscore Jul 10, 2019
e392d16
[twitter] Move added test case at correct place
Lesmiscore Jul 10, 2019
c906e0c
[twitter] Fix user_id extraction instead of regex
Lesmiscore Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion youtube_dl/extractor/twitter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ def _real_extract(self, url):

class TwitterIE(InfoExtractor):
IE_NAME = 'twitter'
_VALID_URL = r'https?://(?:www\.|m\.|mobile\.)?twitter\.com/(?:i/web|(?P<user_id>[^/]+))/status/(?P<id>\d+)'
_VALID_URL = r'https?://(?:www\.|m\.|mobile\.)?twitter\.com/(?:i/web|-|(?P<user_id>[^/]+))/status/(?P<id>\d+)'
Lesmiscore marked this conversation as resolved.
Show resolved Hide resolved
_TEMPLATE_URL = 'https://twitter.com/%s/status/%s'
_TEMPLATE_STATUSES_URL = 'https://twitter.com/statuses/%s'

Expand Down Expand Up @@ -428,6 +428,9 @@ class TwitterIE(InfoExtractor):
'params': {
'skip_download': True, # requires ffmpeg
},
}, {
'url': 'https://twitter.com/-/status/1087791357756956680',
'only_matching': True,
}]

def _real_extract(self, url):
Expand Down