Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[twitter] Allow single dash to be used as username #21705

Closed
wants to merge 3 commits into from
Closed

[twitter] Allow single dash to be used as username #21705

wants to merge 3 commits into from

Conversation

Lesmiscore
Copy link
Contributor

@Lesmiscore Lesmiscore commented Jul 10, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This PR allows to use single dash for username part in video tweet urls.
Taking follwing command as an example,

youtube-dl --output="%(uploader_id).%(ext)" https://twitter.com/-/status/1087791357756956680?s=19

youtube-dl used to save this video in a file named -.mp4, with this PR saved video will be named like twitter.mp4.

youtube_dl/extractor/twitter.py Outdated Show resolved Hide resolved
@dstftw dstftw closed this in b7ef93f Jul 13, 2019
Lamieur referenced this pull request in Lamieur/youtube-dl Apr 20, 2020
Lamieur referenced this pull request in Lamieur/youtube-dl Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants