Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[soundcloud] Fix paged playlist download archival #19086

Closed
wants to merge 7 commits into from

Conversation

CoryDHall
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

rel: #19022

Paged playlists do not work as intended with --download-archive. This attaches missing data by considering additional information already present in the collection.

Copy link

@leonklingele leonklingele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

youtube_dl/extractor/soundcloud.py Outdated Show resolved Hide resolved
youtube_dl/extractor/soundcloud.py Outdated Show resolved Hide resolved
youtube_dl/extractor/soundcloud.py Outdated Show resolved Hide resolved
@CoryDHall
Copy link
Contributor Author

@dstftw

Sorry for the sloppy code, I'm not super familiar with python conventions, and some of the patterns in this extractor are kind of strange

youtube_dl/extractor/soundcloud.py Outdated Show resolved Hide resolved
@dstftw dstftw closed this in 7c5307f Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants