-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--download-archive not efficient (at least with SoundCloud, Vimeo) #19022
Comments
Unfortunately, that can't be changed, as the ID is returned at the same time as the other extracted data. This would require a large rewrite and wouldn't be much more efficient. |
This is not only inefficient, with SoundCloud it leads to IP blocking. Is there some way to have a flag to archive SoundCloud downloads with this part: |
Debugging the requests with |
I was referring to the way |
@ealgase @leonklingele I have a PR that fixes this specifically (just for Soundcloud), but while I was piecing together how this works, I found the extractor can be overhauled to reduce redundant API calls, but I felt it was beyond the scope of this issue (and I am admittedly not super-familiar with the codebase). |
…nload archive id when no explicit ie_key is provided (#19022)
Thanks for merging the fix, @dstftw. This issue also covers archive-inefficiency of Vimeo which I think has not been fixed, so can you please reopen? :-) |
Make sure you are using the latest version: run
youtube-dl --version
and ensure your version is 2019.01.27. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Description of your issue, suggested solution and other information
The
--download-archive
option can be used to record the IDs of downloaded files in an archive soyoutube-dl
does not attempt to download them again. This option works fine with YouTube itself, however doesn't with SoundCloud and Vimeo.When using the option with
[soundcloud:user]
,youtube-dl
still fetches the following information from the Internets:info JSON
track url
m3u8 information
Steps to reproduce
Expected result
On the second execution,
youtube-dl
should skip the first song immediately without downloading any information about it.Actual result
The lines above marked with
# <--
should not happen.Use
https://vimeo.com/stargate
to reproduce with Vimeo.Issue related to #10733.
The text was updated successfully, but these errors were encountered: