Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[requestforcomments] new extractor for requestforcomments podcast #15873

Closed
wants to merge 1 commit into from

Conversation

kayb94
Copy link
Contributor

@kayb94 kayb94 commented Mar 14, 2018

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • New extractor

Description of your pull request and other information

RequestForComments is another podcast, which also uses more or less the same webpage as the Metaebene podcasts (see #15872), but from another producer. This is an extractor for the page (requestforcomments.de). It is not associated with the IETF.
I decided to make two seperate extractors because:

  • I did not want RequestForComments to appear as one of the podcasts of the Metaebene producer, because that would be wrong
  • I did not find a way, to use the logic of MetaebeneIE in RequestForCommentsIE without instantating an object of it or stuff.

As the extraction is very simple, I think it is okay, to keep them as two. This might also help in the future, if either one of the Metaebene pages or the RequestForComments page should change.

@dstftw dstftw force-pushed the master branch 2 times, most recently from 5e26784 to da2069f Compare September 13, 2020 13:51
@dirkf dirkf closed this Aug 1, 2023
@dirkf dirkf added the defunct PR source branch is not accessible label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants