Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metaebene] new extractor for metaebene podcasts #15872

Closed
wants to merge 4 commits into from

Conversation

kayb94
Copy link
Contributor

@kayb94 kayb94 commented Mar 14, 2018

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • New extractor

Description of your pull request and other information

Metaebene.me is the website of a podcast producer, whose podcasts all have the same kind of webpage. This is an extractor for them.

@kayb94
Copy link
Contributor Author

kayb94 commented Mar 17, 2018

I found a mistake, please wait for the next commit (today). Just a small thing.

Regards

@kayb94
Copy link
Contributor Author

kayb94 commented Mar 17, 2018

Good now from my side!

Regards

@kayb94
Copy link
Contributor Author

kayb94 commented Mar 28, 2018

@dstftw
Is this merge request acceptable, or shall I improve something?

@kayb94
Copy link
Contributor Author

kayb94 commented Apr 30, 2018

In case you studied some of the unit tests and wondered, why the extractor is neccessary, when there already is a download button: It requires JS, which of course every user of NoScript and similar tries to circumvent.
Would be great, if this would become available for others, too (and #15873) :) If anything speaks against that, I'd be glad to hear.
I've been using the branch since March multiple times a week and it never failed so far.

Regards

@kayb94
Copy link
Contributor Author

kayb94 commented May 20, 2018

Could someone review?

Regards
Kay

@duracell
Copy link

@rg3 Is nobody active anymore in reviewing PR?

@rg3
Copy link
Collaborator

rg3 commented Jun 24, 2018

Pinging @dstftw again just in case...

@dstftw
Copy link
Collaborator

dstftw commented Jun 24, 2018

This extraction approach should go in the generic extractor.

@dstftw dstftw force-pushed the master branch 2 times, most recently from 5e26784 to da2069f Compare September 13, 2020 13:51
@dirkf dirkf closed this Aug 1, 2023
@dirkf dirkf added the defunct PR source branch is not accessible label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible pending-fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants