[vimeo] fix album extraction (issue #15704) #15855
Conversation
|
This fix fails to extract password protected albums! |
|
As said, that's not what I tried to achieve. Please open a seperate Issue, if you haven't done yet. Regards |
|
@dstftw Is this ready? Regards |
|
Does not work for multi page albums. |
youtube_dl/extractor/vimeo.py
Outdated
| @@ -833,9 +834,16 @@ class VimeoAlbumIE(VimeoChannelIE): | |||
| 'url': 'https://vimeo.com/album/2632481', | |||
| 'info_dict': { | |||
| 'id': '2632481', | |||
| 'title': 'Staff Favorites: November 2013', | |||
| 'title': 'Vimeo / Staff Favorites: November 2013', | |||
There was a problem hiding this comment.
The title is Staff Favorites: November 2013.
youtube_dl/extractor/vimeo.py
Outdated
| return self._extract_videos(album_id, 'https://vimeo.com/album/%s' % album_id) | ||
| rss_url = url + '/rss' | ||
|
|
||
| doc = self._download_xml(rss_url, album_id, fatal=True) |
|
|
||
| doc = self._download_xml(rss_url, album_id, fatal=True) | ||
|
|
||
| playlist_title = doc.find('./channel/title').text |
youtube_dl/extractor/vimeo.py
Outdated
| entries = [] | ||
| for it in doc.findall('./channel/item'): | ||
| next_title = it.find('title').text | ||
| next_url = xpath_text(it, 'link', fatal=False) |
|
Thank you for your review, I incorporated your suggestions. Sadly I was busy and also forgot about it for a while. https://vimeo.com/album/2632481/sort:plays/format:thumbnail. ...appear the same and on one page to me. But I have to admit I never use vimeo. Regards |
|
Could someone review? Regards |
|
I resolved the things you requested, could you review again please @dstftw Regards |
closes #1933 closes #15704 closes #15855 closes #18967 closes #21986
closes #1933 closes #15704 closes #15855 closes #18967 closes #21986
closes #1933 closes #15704 closes #15855 closes #18967 closes #21986
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
(Mixed, took some snippets from elsewhere in youtube-dl)
What is the purpose of your pull request?
Description of your pull request and other information
Fixes the vimeo album playlist extraction. I added a test (from the original bug report). So, this resolves #15704.