[Heise] Add support for new c't uplink episodes #14108
Conversation
|
Can someone merge this? I would really like to have other people be able to download the new c't uplink episodes with youtube-dl, too! |
youtube_dl/extractor/heise.py
Outdated
| video_id, "Downloading alternative XML (SD)") | ||
| hd_rss_feed = self._download_xml( | ||
| 'https://blog.ct.de/ctuplink/ctuplinkvideohd.rss', | ||
| video_id, "Downloading alternative XML (HD)") |
youtube_dl/extractor/heise.py
Outdated
| descriptions = hd_rss_feed.findall('./channel/item/description') | ||
|
|
||
| sd_video_urls = sd_rss_feed.findall('./channel/item/guid') | ||
| hd_video_urls = hd_rss_feed.findall('./channel/item/guid') |
youtube_dl/extractor/heise.py
Outdated
|
|
||
| formats.append({ | ||
| 'url': hd_video_urls[episode_index].text, | ||
| 'height': 720}) |
|
Thanks for the review. Resolved those. |
youtube_dl/extractor/heise.py
Outdated
| video_id, "Downloading alternative XML (SD)"), | ||
| self._download_xml( | ||
| 'https://www.heise.de/ct/uplink/ctuplinkvideohd.rss', | ||
| video_id, "Downloading alternative XML (HD)")] |
There was a problem hiding this comment.
- Code duplication.
- Each should be non fatal.
There was a problem hiding this comment.
for path, format_id in (('', 'audio'), ('video', 'sd'), ('videohd', 'hd')):
self._download_xml(
'https://www.heise.de/ct/uplink/ctuplink%s.rss' % path,
video_id, 'Downloading %s XML' % format_id, fatal=False)
|
Hope this is okay. Just saw your comment afterwards at my mails! |
|
@dstftw Friendly ping: is this ready? |
|
Do not merge yet, please. I tried it again today (new episode) and it did not work. The latest episode is not in the RSS feeds. So either they just did not yet put it in there, or they stopped updating in. Have to investigate first. Regards |
|
@kayb94 Just a friendly ping: how's it going? Do you think you can manage to finish this PR? |
|
@mpenkov This Pull Requests should have been closed, as the original issue has been solved (again) by 8e70c1b But I won't undertake any new efforts, before my long standing open pull requests #16880 and #15855 aren't looked after. Regards |
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Add support for new c't uplink episodes.
The previous way of extraction still works for all content before somewhat 2 weeks ago and might be the only way for some content, thereby still kept.